fix(destination): Rename NewDestinationPlugin to NewPlugin#519
Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom Dec 19, 2022
Merged
Conversation
⏱️ Benchmark resultsComparing with 74c6672
|
yevgenypats
approved these changes
Dec 19, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Nice. I already did it in my Follow-up PR but I get that otherwise we will need to fix breaking compilation changes twice so better to do it once now.
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.7](v1.12.6...v1.12.7) (2022-12-19) ### Bug Fixes * **destination:** Rename `NewDestinationPlugin` to `NewPlugin` ([#519](#519)) ([3934775](3934775)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #516
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)