fix: Validate json strings and handle empty strings#497
Merged
kodiakhq[bot] merged 3 commits intomainfrom Dec 13, 2022
Merged
Conversation
bbernays
reviewed
Dec 13, 2022
| *dst = JSON{Bytes: []byte(value), Status: Present} | ||
| case *string: | ||
| if value == nil { | ||
| *dst = JSON{Status: Null} |
Contributor
There was a problem hiding this comment.
we should return here I think
Contributor
Author
There was a problem hiding this comment.
It's going out of the switch case so it's fine. Not the most consistent code because it's started with switch case the original code from pgtype and now we have more cases where I had to return. Not sure if better to change everything to return.
bbernays
approved these changes
Dec 13, 2022
⏱️ Benchmark resultsComparing with 7154bd0
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.3](v1.12.2...v1.12.3) (2022-12-14) ### Bug Fixes * Throw error on empty env variable ([#499](#499)) ([4b77cf5](4b77cf5)) * Validate json strings and handle empty strings ([#497](#497)) ([dd5f008](dd5f008)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of the work here https://github.com/cloudquery/plugin-sdk/pull/479/files