Skip to content

fix: Module parameter in logs of source-plugins#364

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:logs_module
Nov 7, 2022
Merged

fix: Module parameter in logs of source-plugins#364
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
shimonp21:logs_module

Conversation

@shimonp21
Copy link
Copy Markdown
Contributor

@shimonp21 shimonp21 commented Nov 7, 2022

Summary

Before, 'module' always showed as 'cli', even for source plugins.
destination-plugins will be done in a follow-up PR.

logs before this PR:

2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_wafv2_rule_groups
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_wafv2_web_acls
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_wafv2_web_acls
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_workspaces_workspaces
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_workspaces_workspaces
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_workspaces_directories
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_workspaces_directories
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_xray_encryption_config
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_encryption_config
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_xray_groups
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_groups
2022-11-07T13:13:51Z INF Migrating table module=pg-dest table=aws_xray_sampling_rules
2022-11-07T13:13:51Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_sampling_rules
2022-11-07T13:13:51Z INF finished call grpc.code=OK grpc.component=server grpc.method=Migrate grpc.method_type=unary grpc.service=proto.Destination grpc.start_time=2022-11-07T15:13:49+02:00 grpc.time_ms=1358.043 module=cli protocol=grpc
2022-11-07T13:13:51Z INF Start fetching resources destinations=["postgresql"] module=cli source=aws
2022-11-07T13:13:51Z INF started call grpc.code=OK grpc.component=server grpc.method=Sync2 grpc.method_type=server_stream grpc.service=proto.Source grpc.start_time=2022-11-07T15:13:51+02:00 grpc.time_ms=0.034 module=cli protocol=grpc
2022-11-07T13:13:51Z INF started call grpc.code=OK grpc.component=server grpc.method=Write2 grpc.method_type=client_stream grpc.service=proto.Destination grpc.start_time=2022-11-07T15:13:51+02:00 grpc.time_ms=3.098 module=cli protocol=grpc
2022-11-07T13:13:51Z INF All regions specified in `cloudquery.yml`. Assuming all regions module=cli
2022-11-07T13:13:53Z INF table resolver started client=615713231484:eu-north-1 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:ap-southeast-2 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:eu-west-2 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:us-west-2 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:eu-central-1 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:ap-south-1 module=cli table=aws_ec2_vpcs
2022-11-07T13:13:53Z INF table resolver started client=615713231484:eu-west-1 module=cli table=aws_ec2_vpcs

logs after this PR

2022-11-07T13:17:17Z INF Migrating table module=pg-dest table=aws_workspaces_directories
2022-11-07T13:17:17Z INF Table exists, auto-migrating module=pg-dest table=aws_workspaces_directories
2022-11-07T13:17:17Z INF Migrating table module=pg-dest table=aws_xray_encryption_config
2022-11-07T13:17:17Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_encryption_config
2022-11-07T13:17:17Z INF Migrating table module=pg-dest table=aws_xray_groups
2022-11-07T13:17:17Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_groups
2022-11-07T13:17:17Z INF Migrating table module=pg-dest table=aws_xray_sampling_rules
2022-11-07T13:17:17Z INF Table exists, auto-migrating module=pg-dest table=aws_xray_sampling_rules
2022-11-07T13:17:17Z INF finished call grpc.code=OK grpc.component=server grpc.method=Migrate grpc.method_type=unary grpc.service=proto.Destination grpc.start_time=2022-11-07T15:17:16+02:00 grpc.time_ms=1127.082 module=cli protocol=grpc
2022-11-07T13:17:17Z INF Start fetching resources destinations=["postgresql"] module=cli source=aws
2022-11-07T13:17:17Z INF started call grpc.code=OK grpc.component=server grpc.method=Sync2 grpc.method_type=server_stream grpc.service=proto.Source grpc.start_time=2022-11-07T15:17:17+02:00 grpc.time_ms=0.037 module=cli protocol=grpc
2022-11-07T13:17:17Z INF started call grpc.code=OK grpc.component=server grpc.method=Write2 grpc.method_type=client_stream grpc.service=proto.Destination grpc.start_time=2022-11-07T15:17:17+02:00 grpc.time_ms=3.896 module=cli protocol=grpc
2022-11-07T13:17:17Z INF All regions specified in `cloudquery.yml`. Assuming all regions module=aws-src
2022-11-07T13:17:19Z INF table resolver started client=615713231484:eu-central-1 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:us-east-2 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:ap-southeast-2 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:ap-south-1 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:ap-northeast-1 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:eu-west-2 module=aws-src table=aws_ec2_vpcs
2022-11-07T13:17:19Z INF table resolver started client=615713231484:eu-west-3 module=aws-src table=aws_ec2_vpcs

@github-actions github-actions bot added the fix label Nov 7, 2022
yevgenypats
yevgenypats approved these changes Nov 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just wasn't sure if we should set it inside or outside but both works.

@shimonp21 shimonp21 changed the title fix: 'module' parameter in logs of source-plugins fix: Module parameter in logs of source-plugins Nov 7, 2022
@github-actions github-actions bot added fix and removed fix labels Nov 7, 2022
@kodiakhq kodiakhq bot merged commit 379d3e6 into cloudquery:main Nov 7, 2022
@cq-bot cq-bot mentioned this pull request Nov 7, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 7, 2022
@cq-bot
chore(main): Release v1.0.1 (#365)
a4ac1b2 
🤖 I have created a release *beep* *boop*
---


## [1.0.1](v1.0.0...v1.0.1) (2022-11-07)


### Bug Fixes

* Module parameter in logs of source-plugins ([#364](#364)) ([379d3e6](379d3e6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shimonp21 @yevgenypats