fix: Parsing timestamptz default string#336
Merged
kodiakhq[bot] merged 4 commits intomainfrom Nov 1, 2022
Merged
Conversation
hermanschaaf
reviewed
Nov 1, 2022
|
|
||
| if len(sbuf) > len(defaultStringFormat)+1 && sbuf[len(defaultStringFormat)+1] == 'm' { | ||
| sbuf = sbuf[:len(defaultStringFormat)] | ||
| } |
Contributor
There was a problem hiding this comment.
Can we add a test for this case?
Member
|
What's the edge case, can you comment in the code? is |
Contributor
Author
It's not valid, if you look at |
hermanschaaf
approved these changes
Nov 1, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
🤖 I have created a release *beep* *boop* --- ## [0.13.18](v0.13.17...v0.13.18) (2022-11-01) ### Bug Fixes * Parsing timestamptz default string ([#336](#336)) ([acdcb02](acdcb02)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another edge-case