Merged
Conversation
yevgenypats
approved these changes
Oct 7, 2022
Contributor
|
Nice catch! |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 9, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.10](v0.12.9...v0.12.10) (2022-10-09) ### Bug Fixes * Add missing defer ([#260](#260)) ([1ee7829](1ee7829)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waitgroup here should defer before being marked as done. Spotted this while looking through the code, but this wasn't causing any serious issues as far as I'm aware though.