feat: Add Close() to destination interface and new writemode#211
Merged
yevgenypats merged 7 commits intomainfrom Oct 1, 2022
Merged
feat: Add Close() to destination interface and new writemode#211yevgenypats merged 7 commits intomainfrom
yevgenypats merged 7 commits intomainfrom
Conversation
This is useful for destinations where you need to close the file(s) or connections after a sync is done
yevgenypats
approved these changes
Oct 1, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Nice. Also added new writemode overwrite-deletestale which will give destination plugins to delete stale data on close
yevgenypats
pushed a commit
that referenced
this pull request
Oct 1, 2022
🤖 I have created a release *beep* *boop* --- ## [0.11.4](v0.11.3...v0.11.4) (2022-10-01) ### Features * Add Close() to destination interface and new writemode ([#211](#211)) ([8af6fcb](8af6fcb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful in cases where the destination plugin may need to close files or connections, or perform a final flush, when the sync is done.