feat: Enable storing _cq_client_id.#2046
Merged
marianogappa merged 2 commits intomainfrom Jan 8, 2025
Merged
Conversation
dcelasun
approved these changes
Jan 8, 2025
erezrokah
approved these changes
Jan 8, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
🤖 I have created a release *beep* *boop* --- ## [4.73.0](v4.72.6...v4.73.0) (2025-01-08) ### Features * Enable storing _cq_client_id. ([#2046](#2046)) ([3b28991](3b28991)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to store
_cq_client_idon every table for certain use cases where we need to know where a row came from in terms of multiplexed clients.This PR adds the ability for the SDK and all its schedulers to store
_cq_client_idon all tables.I added this feature to the example plugin in the SDK and it does store it properly:
If you want to try this yourself, please note that, very unfortunately, the simple plugin also stores a
client_idcolumn that is unrelated (and doesn't work, since it thinks it's supposed to be an integer).