Merged
Conversation
bd89d1f to
3ae4778
Compare
5 tasks
marianogappa
approved these changes
Dec 10, 2024
226d3a0 to
4650d01
Compare
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
🤖 I have created a release *beep* *boop* --- ## [4.72.0](v4.71.1...v4.72.0) (2024-12-13) ### Features * Update to Arrow v18 ([#1997](#1997)) ([5b84d3d](5b84d3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/filetypes
that referenced
this pull request
Dec 13, 2024
#### Summary Needs cloudquery/plugin-sdk#1997 ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-pb-go#445
Interesting bit is https://arrow.apache.org/blog/2024/10/23/arrow-go-18.0.0-release/#canonical-extension-types that we might be able to drop our UUID and JSON own extension types, but probably better to do that separately
Had to do 3ae4778 to get the tests working, followed apache/arrow#43679 as a reference
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)