feat: Add IsPaid flag to table definition#1327
Conversation
There was a problem hiding this comment.
It looks good - one thing that Im afraid with tags is that if we use it for things like isPaid we loose the whole Golang/gRPC static/api checks. I feel like tags are just for things like docs and metadata and not for things that are part of a protocol essentially.
⏱️ Benchmark results
|
|
@yevgenypats The reason to have tags as part of the Arrow metadata, even isPaid, is essentially only for docs. Other than for docs generation, the CLI won't use this. There aren't plans for destinations to use this either. However we do plan to use it to check whether we should check the quota for a given table before proceeding with the sync (within the Go SDK). The |
|
Updated to be explicit and add |
🤖 I have created a release *beep* *boop* --- ## [4.17.0](v4.16.1...v4.17.0) (2023-10-30) ### Features * Add IsPaid flag to table definition ([#1327](#1327)) ([ffd14bf](ffd14bf)) * Add OnBeforeSend hook ([#1325](#1325)) ([023ebbc](023ebbc)) * Adding a batch updater to allow usage updates to be batched ([#1326](#1326)) ([0301ed7](0301ed7)) * Adding quota monitoring for premium plugins ([#1333](#1333)) ([b7a2ca5](b7a2ca5)) * Allow sync to be cancelled when in progress ([#1334](#1334)) ([6d7be0b](6d7be0b)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 50d3871 ([#1337](#1337)) ([f15a89d](f15a89d)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to f46436f ([#1329](#1329)) ([ee24384](ee24384)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.2 ([#1335](#1335)) ([2ecd2a1](2ecd2a1)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.13.0 ([#1332](#1332)) ([5553f85](5553f85)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.13.1 ([#1336](#1336)) ([b782ee7](b782ee7)) * **deps:** Update module google.golang.org/grpc to v1.58.3 [SECURITY] ([#1331](#1331)) ([43f60c2](43f60c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This adds an
IsPaidflag to the table definition. This can be used by premium plugins to indicate that a certain table is paid.