feat: Support publishing plugins with team and kind metadata set#1313
Merged
hermanschaaf merged 8 commits intomainfrom Oct 19, 2023
Merged
feat: Support publishing plugins with team and kind metadata set#1313hermanschaaf merged 8 commits intomainfrom
hermanschaaf merged 8 commits intomainfrom
Conversation
mnorbury
reviewed
Oct 18, 2023
| "github.com/cloudquery/plugin-sdk/v4/plugin" | ||
| ) | ||
|
|
||
| // These variables are set as part of the `package` command |
Contributor
There was a problem hiding this comment.
Is this comment correct now?
mnorbury
approved these changes
Oct 18, 2023
disq
approved these changes
Oct 18, 2023
Contributor
Author
|
I'll merge this soon. After it rolls out, we'll need to update all the source plugins that are published to the new registry to set these new properties. |
hermanschaaf
pushed a commit
that referenced
this pull request
Oct 19, 2023
🤖 I have created a release *beep* *boop* --- ## [4.16.0](v4.15.3...v4.16.0) (2023-10-19) ### Features * Support publishing plugins with team and kind metadata set ([#1313](#1313)) ([933698d](933698d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to package the plugin with team and kind metadata set, needed for publishing to the new registry and checking usage and limits against the new cloud API.
The package command no longer needs to take a
kindargument.Also adds an
infocommand to print this information, useful for debugging, otherwise it won't be visible anywhere. We can consider adding this to the--versionoutput instead, but that would technically be breaking?