fix(package): Don't init destinations during package#1249
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Sep 27, 2023
Merged
fix(package): Don't init destinations during package#1249kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 48.89% 48.89%
=======================================
Files 89 89
Lines 8313 8313
=======================================
Hits 4065 4065
Misses 3873 3873
Partials 375 375
☔ View full report in Codecov by Sentry. |
⏱️ Benchmark results
|
hermanschaaf
approved these changes
Sep 27, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Ok let's go with this for now, but I'd suggest adding opening an issue to support NoConnection in destinations
Closed
1 task
Member
Author
|
Opened in cloudquery/cloudquery#14059 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [4.11.1](v4.11.0...v4.11.1) (2023-09-27) ### Bug Fixes * **package:** Don't init destinations during package ([#1249](#1249)) ([f21e963](f21e963)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1248
Another option that we could do (or do both) is handle
NoConnectionin all destinations.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)