fix: Rename plugin type -> kind for consistency with existing configs#1240
Merged
kodiakhq[bot] merged 1 commit intomainfrom Sep 21, 2023
Merged
fix: Rename plugin type -> kind for consistency with existing configs#1240kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 89 89
Lines 8310 8310
=======================================
Hits 4056 4056
Misses 3877 3877
Partials 377 377
☔ View full report in Codecov by Sentry. |
disq
approved these changes
Sep 21, 2023
Member
|
Good catch! |
erezrokah
approved these changes
Sep 21, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.10.2](v4.10.1...v4.10.2) (2023-09-21) ### Bug Fixes * Rename plugin type -> kind for consistency with existing configs ([#1240](#1240)) ([a00b8d0](a00b8d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized existing plugin configs use the word
kind(e.g.kind: source) and nottype. Let's just stick to one word everywhere for consistency.