feat: Extensive testing for delete-stale#1175
Merged
kodiakhq[bot] merged 20 commits intomainfrom Aug 31, 2023
Merged
Conversation
f632113 to
9d42b71
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
- Coverage 48.71% 48.46% -0.26%
==========================================
Files 87 87
Lines 8080 8124 +44
==========================================
+ Hits 3936 3937 +1
- Misses 3787 3830 +43
Partials 357 357
☔ View full report in Codecov by Sentry. |
candiduslynx
commented
Aug 30, 2023
hermanschaaf
approved these changes
Aug 31, 2023
erezrokah
approved these changes
Aug 31, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
🤖 I have created a release *beep* *boop* --- ## [4.6.0](v4.5.7...v4.6.0) (2023-08-31) ### Features * Extensive testing for `delete-stale` ([#1175](#1175)) ([304e4eb](304e4eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extensive test for
delete-stalescenario.Tested via cloudquery/cloudquery#13477
We are now testing a
delete-stalecase verifying the amount of records after each time we write data.This way we can ensure that the data is properly handled by the destinations that support
delete-stalerequests.Additionally, the test uses the table schema generated based on the suite options.