fix(testing): Force migrations should allow table drops#1101
Merged
disq merged 2 commits intocloudquery:mainfrom Jul 18, 2023
disq:fix/force-migrations-accept-drop
Merged
fix(testing): Force migrations should allow table drops#1101disq merged 2 commits intocloudquery:mainfrom disq:fix/force-migrations-accept-drop
disq merged 2 commits intocloudquery:mainfrom
disq:fix/force-migrations-accept-drop
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 47.02% 47.01% -0.01%
==========================================
Files 85 85
Lines 7777 7778 +1
==========================================
Hits 3657 3657
- Misses 3785 3786 +1
Partials 335 335
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more flexible approach than #1100
In plugin's migration handling code, there's no easy way to decide if we should drop the table or not for some plugins. If force flag is set, the plugin is allowed to drop previous data.