fix: Validate versions only for github registry (#188)

shimonp21 · web-flow · commit 7f9a3ba8dc31 · 2022-09-28T08:52:01.000Z
#### Summary   --- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑‍🎓 - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅
diff --git a/specs/destination.go b/specs/destination.go
@@ -50,12 +50,16 @@ func (d *Destination) Validate() error {
 	if d.Name == "" {
 		return fmt.Errorf("name is required")
 	}
-	if d.Version == "" {
-		return fmt.Errorf("version is required")
-	}
-	if !strings.HasPrefix(d.Version, "v") {
-		return fmt.Errorf("version must start with v")
+
+	if d.Registry == RegistryGithub {
+		if d.Version == "" {
+			return fmt.Errorf("version is required")
+		}
+		if !strings.HasPrefix(d.Version, "v") {
+			return fmt.Errorf("version must start with v")
+		}
 	}
+
 	return nil
 }
 
diff --git a/specs/source.go b/specs/source.go
@@ -64,12 +64,16 @@ func (s *Source) Validate() error {
 	if s.Name == "" {
 		return fmt.Errorf("name is required")
 	}
-	if s.Version == "" {
-		return fmt.Errorf("version is required")
-	}
-	if !strings.HasPrefix(s.Version, "v") {
-		return fmt.Errorf("version must start with v")
+
+	if s.Registry == RegistryGithub {
+		if s.Version == "" {
+			return fmt.Errorf("version is required")
+		}
+		if !strings.HasPrefix(s.Version, "v") {
+			return fmt.Errorf("version must start with v")
+		}
 	}
+
 	if len(s.Destinations) == 0 {
 		return fmt.Errorf("at least one destination is required")
 	}
