fix: Remove DisallowUnknownFields from Source plugin server (#277)

hermanschaaf · web-flow · commit 0fcf813141c8 · 2022-10-11T10:58:20.000+01:00
See cloudquery/cloudquery#2612 for an explanation. Notes: - We weren't using `DisallowUnknownFields` on the destination plugin side - We don't currently have a mechanism to warn about unknown fields, but we are working on it #272 - This will unfortunately not fix plugins that have already been released. Our next CLI release that adds new fields will have to be breaking, but after that they can be backwards-compatible.
diff --git a/internal/servers/source.go b/internal/servers/source.go
@@ -61,7 +61,7 @@ func (s *SourceServer) Sync(req *pb.Sync_Request, stream pb.Source_SyncServer) e
 	var spec specs.Source
 	dec := json.NewDecoder(bytes.NewReader(req.Spec))
 	dec.UseNumber()
-	dec.DisallowUnknownFields()
+	// TODO: warn about unknown fields
 	if err := dec.Decode(&spec); err != nil {
 		return status.Errorf(codes.InvalidArgument, "failed to decode spec: %v", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func (s SourceServer) Sync(req pb.Sync_Request, stream pb.Source_SyncServer) e`
`61`	`61`	`var spec specs.Source`
`62`	`62`	`dec := json.NewDecoder(bytes.NewReader(req.Spec))`
`63`	`63`	`dec.UseNumber()`
`64`		`- dec.DisallowUnknownFields()`
	`64`	`+ // TODO: warn about unknown fields`
`65`	`65`	`if err := dec.Decode(&spec); err != nil {`
`66`	`66`	`return status.Errorf(codes.InvalidArgument, "failed to decode spec: %v", err)`
`67`	`67`	`}`