This repository was archived by the owner on Aug 12, 2022. It is now read-only.
fix: Put example YAML from the provider in configuration block#388
Merged
fix: Put example YAML from the provider in configuration block#388
configuration block#388Conversation
yevgenypats
approved these changes
Jun 27, 2022
erezrokah
approved these changes
Jun 27, 2022
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.5](v0.12.4...v0.12.5) (2022-06-27) ### Bug Fixes * Put example YAML from the provider in `configuration` block ([#388](#388)) ([1e06428](1e06428)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to what the comment says, it can't be removed from the code (not a way I could find) because then the comments aren't processed, so they are omitted.Any string monkey operations should be done on cq-core side (as core needs a valid YAML, otherwise the comments will probably get dropped again) so that's why I avoided them.This is the best we can do with the
\n \nthing, double newlines will abort a comment block and!!nullyaml tags can't have them. Indentation is not right but it's close enough: