Skip to content

feat: Allow configurable config home directory#42

Merged
kodiakhq[bot] merged 4 commits intomainfrom
feat/allow-configurable-config-home
Oct 17, 2023
Merged

feat: Allow configurable config home directory#42
kodiakhq[bot] merged 4 commits intomainfrom
feat/allow-configurable-config-home

Conversation

@mnorbury
Copy link
Contributor

No description provided.

@mnorbury mnorbury requested a review from hermanschaaf October 17, 2023 14:46
Copy link
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we might also need some similar functions for setting the XDG Data directory.

Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
@mnorbury mnorbury force-pushed the feat/allow-configurable-config-home branch from 78f93c0 to db1642d Compare October 17, 2023 14:49
@mnorbury
Copy link
Contributor Author

Looks good, though we might also need some similar functions for setting the XDG Data directory.

Good point. Hopefully not over the top, but d532a83 now confines xdg dependency to the config package and allows both config and data directories to be configured.

@mnorbury mnorbury added the automerge Add to automerge PRs once requirements are met label Oct 17, 2023
@kodiakhq kodiakhq bot merged commit 3235143 into main Oct 17, 2023
@kodiakhq kodiakhq bot deleted the feat/allow-configurable-config-home branch October 17, 2023 15:37
kodiakhq bot pushed a commit that referenced this pull request Oct 17, 2023
🤖 I have created a release *beep* *boop*
---


## [1.4.0](v1.3.0...v1.4.0) (2023-10-17)


### Features

* Allow configurable config home directory ([#42](#42)) ([3235143](3235143))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to automerge PRs once requirements are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants