fix: Remove JSON schema validation warnings #17994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
approved these changes
May 17, 2024
5 tasks
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
May 17, 2024
#### Summary Similar to cloudquery/cloudquery#17994. It keeps the code that checks that the schema itself is a valid to ensure plugins embed a valid one ---
kodiakhq bot
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- ## [5.19.0](cli-v5.18.2...cli-v5.19.0) (2024-05-17) ### Features * Sync Metadata table ([#17842](#17842)) ([377bde2](377bde2)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.42.1 ([#17965](#17965)) ([d652b81](d652b81)) * Remove JSON schema validation warnings ([#17994](#17994)) ([7a7ff25](7a7ff25)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/cloudquery/cloudquery-issues/issues/1676 (internal issue). We're moving JSON schema validation to only be in the Cloud and use the current validation login in the CLI.
We can't remove it fully at the moment as it's used by the
validate-configcommand, so that would come later on