feat: Add team context selection via switch#14493
Merged
kodiakhq[bot] merged 6 commits intomainfrom Oct 10, 2023
Merged
Conversation
switch
Contributor
Author
|
|
erezrokah
approved these changes
Oct 10, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, one question on cloudquery switch
Member
This is fine since we don't use API keys at the moment |
erezrokah
pushed a commit
that referenced
this pull request
Oct 12, 2023
🤖 I have created a release *beep* *boop* --- ## [3.22.0](cli-v3.21.3...cli-v3.22.0) (2023-10-12) ### Features * Add team context selection via `switch` ([#14493](#14493)) ([d5a7cde](d5a7cde)) * Update CloudQuery Go API client, remove docs title, ordinal position ([#14498](#14498)) ([f91786b](f91786b)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([#14459](#14459)) ([7ce40f8](7ce40f8)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([#14475](#14475)) ([83fe7ca](83fe7ca)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([#14489](#14489)) ([9bb45dc](9bb45dc)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([#14500](#14500)) ([9e603d5](9e603d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
This change is focused around adding the ability to set a team context via a new `cloudquery switch` command that takes a team name, but also introduces a few other features that are adjacent to that: - Adds `cloudquery switch` (prints current team) and `cloudquery switch <team>` (switches team) - Adds a `cloudquery logout` command to log out - Adds a `--team` option to `cloudquery login` as shorthand for `cloudquery login` followed by `cloudquery switch <team>` - Introduces a `config` library for managing config files. We currently only store a `team` value, but this may be extended in the future. - Removes the `--url` parameter from `cloudquery publish` and uses an environment variable for this instead. Usually we don't use environment variables, but in this case it is intentional, because you would only ever need to set the URL in tests. - All tests now use environment variables for overriding the API and accounts URLs - Renaming `CQ_API_KEY` to `CLOUDQUERY_API_KEY` for clarity and consistency (we will have to update the publish CI job to handle this CC @erezrokah)
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [3.22.0](cloudquery/cloudquery@cli-v3.21.3...cli-v3.22.0) (2023-10-12) ### Features * Add team context selection via `switch` ([cloudquery#14493](cloudquery#14493)) ([d5a7cde](cloudquery@d5a7cde)) * Update CloudQuery Go API client, remove docs title, ordinal position ([cloudquery#14498](cloudquery#14498)) ([f91786b](cloudquery@f91786b)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([cloudquery#14459](cloudquery#14459)) ([7ce40f8](cloudquery@7ce40f8)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([cloudquery#14475](cloudquery#14475)) ([83fe7ca](cloudquery@83fe7ca)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([cloudquery#14489](cloudquery#14489)) ([9bb45dc](cloudquery@9bb45dc)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([cloudquery#14500](cloudquery#14500)) ([9e603d5](cloudquery@9e603d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is focused around adding the ability to set a team context via a new
cloudquery switchcommand that takes a team name, but also introduces a few other features that are adjacent to that:cloudquery switch(prints current team) andcloudquery switch <team>(switches team)cloudquery logoutcommand to log out--teamoption tocloudquery loginas shorthand forcloudquery loginfollowed bycloudquery switch <team>configlibrary for managing config files. We currently only store ateamvalue, but this may be extended in the future.--urlparameter fromcloudquery publishand uses an environment variable for this instead. Usually we don't use environment variables, but in this case it is intentional, because you would only ever need to set the URL in tests.CQ_API_KEYtoCLOUDQUERY_API_KEYfor clarity and consistency (we will have to update the publish CI job to handle this CC @erezrokah)