fix: Slugify docs names before publishing#14054
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Sep 27, 2023
Merged
fix: Slugify docs names before publishing#14054kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
Conversation
cli/cmd/publish_test.go
Outdated
| }, | ||
| map[string]any{ | ||
| "content": customDocContent, | ||
| "name": "custom-doc", |
Contributor
There was a problem hiding this comment.
Is this slug expected to come from the name of the doc, or from the slug in the frontmatter? Maybe we should make the slug in the frontmatter differ to make this clear?
Member
Author
There was a problem hiding this comment.
Updated the tests a bit, good point
Contributor
There was a problem hiding this comment.
Great, thanks :) I think the slug field in the frontmatter is not being used, should we remove it?
hermanschaaf
approved these changes
Sep 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [3.19.3](cli-v3.19.2...cli-v3.19.3) (2023-09-27) ### Bug Fixes * Slugify docs names before publishing ([#14054](#14054)) ([a0fb8ab](a0fb8ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
#### Summary Follow up to #14054 <!--
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
#### Summary Follow up to cloudquery/cloudquery#14054 <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See https://github.com/cloudquery/cloudquery/actions/runs/6323457020/job/17171062956#step:8:10
We started enforcing this recently