feat: Add install command to pre-install required plugins#13941
feat: Add install command to pre-install required plugins#13941kodiakhq[bot] merged 14 commits intomainfrom
install command to pre-install required plugins#13941Conversation
cli/cmd/root.go
Outdated
| NewCmdSync(), | ||
| NewCmdMigrate(), | ||
| newCmdDoc(), | ||
| newCmdDownload(), |
install command to pre-install required plugins
176d6ce to
68392c4
Compare
hermanschaaf
left a comment
There was a problem hiding this comment.
This looks good 🚀 Just missing a test for the new command :)
Added in |
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks good, just one comment about testing
cli/cmd/install_test.go
Outdated
| "plugins/destination/cloudquery/test/v2.1.0/plugin", | ||
| "plugins/destination/cloudquery/test/v2.1.0/plugin.zip", | ||
| "plugins/destination/cloudquery/test/v2.2.7/plugin", | ||
| "plugins/destination/cloudquery/test/v2.2.7/plugin.zip", |
There was a problem hiding this comment.
I believe these versions get updated automatically by bots (https://github.com/cloudquery/cloudquery/blob/main/cli/cmd/testdata/multiple-destinations.yml#L19) so we will need to read them from the config or keep them in sync some other way for those automated PRs to succeed
There was a problem hiding this comment.
This is the regex we use https://github.com/cloudquery/.github/blob/c43e6ce1c7e117aa0da14aff24ec15df002fe0a6/.github/renovate-default.json5#L87 so if you create a new spec without the comment it won't automatically update the versions
There was a problem hiding this comment.
For example
pins the source versionThere was a problem hiding this comment.
Updated the test to use file counts, not specific versions
🤖 I have created a release *beep* *boop* --- ## [3.21.0](cli-v3.20.0...cli-v3.21.0) (2023-09-29) ### Features * Add `install` command to pre-install required plugins ([#13941](#13941)) ([c225107](c225107)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…ry#13941) Fixes cloudquery#13937 Requires cloudquery/plugin-pb-go#103 (merged/tagged)
🤖 I have created a release *beep* *boop* --- ## [3.21.0](cloudquery/cloudquery@cli-v3.20.0...cli-v3.21.0) (2023-09-29) ### Features * Add `install` command to pre-install required plugins ([cloudquery#13941](cloudquery#13941)) ([c225107](cloudquery@c225107)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #13937
Requires cloudquery/plugin-pb-go#103 (merged/tagged)