fix: Skip incremental tables when performing delete-stale#13482
Merged
kodiakhq[bot] merged 2 commits intomainfrom Aug 30, 2023
Merged
fix: Skip incremental tables when performing delete-stale#13482kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
erezrokah
approved these changes
Aug 30, 2023
Contributor
Author
@erezrokah You're probably right; v2 was still a batch protocol so it's quite different, it's not immediately clear to me how we can fix it there. I think I'm going to defer fixing this, and if we get a report of a community v2 source that also uses incremental tables we can take another look (or upgrade the source to v3, which might be easier) |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.16.1](cli-v3.16.0...cli-v3.16.1) (2023-08-30) ### Bug Fixes * Skip incremental tables when performing delete-stale ([#13482](#13482)) ([2ce7387](2ce7387)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced with the migration to SDK v4 / Protocol v3; when
overwrite-delete-stalewrite mode is used, stale entries should not be removed from incremental tables when a state backend is active.