fix: Call types.RegisterAllExtensions only once in tables command#13411
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Aug 30, 2023
Merged
Conversation
types.RegisterAllExtensions only oncetypes.RegisterAllExtensions only once
types.RegisterAllExtensions only oncetypes.RegisterAllExtensions only once in tables command
Member
Author
|
Looking at the build failures |
Member
Author
|
Ah, need to use a newer Go version |
4ee47c5 to
c8302fe
Compare
erezrokah
commented
Aug 29, 2023
| cmd, cqDir := getTablesCommand(t, tc.config, tc.format) | ||
| commandError := cmd.Execute() | ||
| require.Error(t, commandError, tc.err) | ||
| require.NoError(t, commandError) |
Member
Author
There was a problem hiding this comment.
These tests were passing since we were still throwing an error. When I wrote these I should have validated the error message too
erezrokah
commented
Aug 29, 2023
| module github.com/cloudquery/cloudquery/cli | ||
|
|
||
| go 1.20 | ||
| go 1.21.0 |
Member
Author
There was a problem hiding this comment.
Needed for OnceValue
candiduslynx
approved these changes
Aug 30, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.15.1](cli-v3.15.0...cli-v3.15.1) (2023-08-30) ### Bug Fixes * Call `types.RegisterAllExtensions` only once in `tables` command ([#13411](#13411)) ([041cb8d](041cb8d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed while working on #13410.
RegisterAllExtensionsfails if you call it multiple times. To reproduce run on a spec with multiple sources