feat: Add optional login to our future registry#13201
Merged
kodiakhq[bot] merged 16 commits intomainfrom Sep 6, 2023
Merged
Conversation
erezrokah
requested changes
Aug 21, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good overall, requesting changes due to the config comment. Please let me know what you think
erezrokah
reviewed
Aug 21, 2023
Contributor
|
I'll be overtaking the code + move to https://pkg.go.dev/github.com/pkg/browser instead of own impl |
89f7279 to
ae7fd2d
Compare
ae7fd2d to
a4943c5
Compare
6911e8c to
367de0b
Compare
Contributor
|
/gen sha=4384386092d0b78e0ba7fc31d323d4f94fec9887 component=cli |
Member
@candiduslynx This command is only supported for source plugins at the moment, see |
This reverts commit 9c60c37.
df12dcf to
8b46e9d
Compare
erezrokah
reviewed
Sep 5, 2023
Contributor
|
@erezrokah tested the code manually (seems to work with current deployment) |
candiduslynx
previously approved these changes
Sep 6, 2023
erezrokah
reviewed
Sep 6, 2023
| Local plugins and different registries don't need login. | ||
| ` | ||
|
|
||
| accountsURL = "https://accounts.cloudquery.io" |
Member
There was a problem hiding this comment.
[non blocking] Can we add a hidden option to override this?
erezrokah
approved these changes
Sep 6, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
🤖 I have created a release *beep* *boop* --- ## [3.17.0](cli-v3.16.3...cli-v3.17.0) (2023-09-07) ### Features * Add optional login to our future registry ([#13201](#13201)) ([6a2258e](6a2258e)) * Update migrate command description ([#13752](#13752)) ([f31037e](f31037e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.7.0 ([#13625](#13625)) ([bb5463f](bb5463f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.7.1 ([#13713](#13713)) ([73004dc](73004dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional login to our CLI. This is not connected to our hub yet.
This works similarly to
gcloud auth login.~/.cloudquery/tokenThe command currently is Hidden because our hub is not up yet where it will be needed.