fix: Send delete stale when --no-migrate is used (#13310)

erezrokah · web-flow · commit 92326761f57b · 2023-08-24T12:04:24.000Z
#### Summary Fixes #13281 <!--
diff --git a/cli/cmd/sync_v3.go b/cli/cmd/sync_v3.go
@@ -197,15 +197,15 @@ func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, d
 				}
 			}
 		case *plugin.Sync_Response_MigrateTable:
-			if noMigrate {
-				continue
-			}
 			sc, err := plugin.NewSchemaFromBytes(m.MigrateTable.Table)
 			if err != nil {
 				return err
 			}
 			tableName := tableNameFromSchema(sc)
 			tables[tableName] = true
+			if noMigrate {
+				continue
+			}
 			for i := range destinationsPbClients {
 				transformedSchema := destinationTransformers[i].TransformSchema(sc)
 				transformedSchemaBytes, err := plugin.SchemaToBytes(transformedSchema)

Original file line number	Diff line number	Diff line change
`@@ -197,15 +197,15 @@ func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, d`
`197`	`197`	`}`
`198`	`198`	`}`
`199`	`199`	`case *plugin.Sync_Response_MigrateTable:`
`200`		`- if noMigrate {`
`201`		`- continue`
`202`		`- }`
`203`	`200`	`sc, err := plugin.NewSchemaFromBytes(m.MigrateTable.Table)`
`204`	`201`	`if err != nil {`
`205`	`202`	`return err`
`206`	`203`	`}`
`207`	`204`	`tableName := tableNameFromSchema(sc)`
`208`	`205`	`tables[tableName] = true`
	`206`	`+ if noMigrate {`
	`207`	`+ continue`
	`208`	`+ }`
`209`	`209`	`for i := range destinationsPbClients {`
`210`	`210`	`transformedSchema := destinationTransformers[i].TransformSchema(sc)`
`211`	`211`	`transformedSchemaBytes, err := plugin.SchemaToBytes(transformedSchema)`