Skip to content

[D1] teach wrangler about Australia#5526

Merged
petebacondarwin merged 4 commits intomainfrom
rozenmd/wrangler-australia
Apr 5, 2024
Merged

[D1] teach wrangler about Australia#5526
petebacondarwin merged 4 commits intomainfrom
rozenmd/wrangler-australia

Conversation

@rozenmd
Copy link
Copy Markdown
Contributor

@rozenmd rozenmd commented Apr 5, 2024

What this PR solves / how to test

This PR teaches wrangler about Australia, and fixes up some loose ends.

Fixes #5505

Author has addressed the following

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: bc4c043

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rozenmd rozenmd requested review from a team as code owners April 5, 2024 06:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-wrangler-5526

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5526/npm-package-wrangler-5526

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-wrangler-5526 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-create-cloudflare-5526 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-cloudflare-kv-asset-handler-5526
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-miniflare-5526
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-cloudflare-pages-shared-5526
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8566341550/npm-package-cloudflare-vitest-pool-workers-5526

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.47.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240404.0
workerd 1.20240404.0 1.20240404.0
workerd --version 1.20240404.0 2024-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

rozenmd added a commit to cloudflare/cloudflare-docs that referenced this pull request Apr 5, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.45%. Comparing base (52e9c71) to head (bc4c043).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5526      +/-   ##
==========================================
+ Coverage   72.15%   72.45%   +0.30%     
==========================================
  Files         332      332              
  Lines       17249    17252       +3     
  Branches     4408     4410       +2     
==========================================
+ Hits        12446    12500      +54     
+ Misses       4803     4752      -51     
Files Coverage Δ
packages/wrangler/src/d1/constants.ts 100.00% <100.00%> (ø)
packages/wrangler/src/d1/create.tsx 80.00% <ø> (+43.33%) ⬆️
packages/wrangler/src/d1/info.tsx 61.01% <50.00%> (+41.37%) ⬆️

... and 8 files with indirect coverage changes

},
body: JSON.stringify({
name,
experimental: true,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API no longer requires this - all created DBs have been using the new backend for about 8 months now

storage backend is not yet recommended for production workloads, but
backs up your data via point-in-time restore.
</Text>
<Text>Created your new D1 database.</Text>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more caveats.

delete output["file_size"];
}
if (output["version"] !== "alpha") {
delete output["version"];
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DB version is only relevant if it's alpha

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests! ❤️

@petebacondarwin petebacondarwin merged commit bafbd67 into main Apr 5, 2024
@petebacondarwin petebacondarwin deleted the rozenmd/wrangler-australia branch April 5, 2024 10:25
@workers-devprod workers-devprod mentioned this pull request Apr 5, 2024
rozenmd added a commit to cloudflare/cloudflare-docs that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: d1 create doesn't know about Australia

3 participants