Skip to content

Swallow parsing errors#5494

Merged
penalosa merged 2 commits intomainfrom
penalosa/pages-handle-parsing-errors
Apr 3, 2024
Merged

Swallow parsing errors#5494
penalosa merged 2 commits intomainfrom
penalosa/pages-handle-parsing-errors

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Apr 3, 2024

What this PR solves / how to test

Swallow parsing errors when a pages config file is required. This prevents builds failing with invalid non-pages config files. It also means that invalid config file that were intended for Pages will be ignored, which is slightly unfortunate, but we should err on the side of not breaking existing users.

Author has addressed the following

@penalosa penalosa requested review from a team as code owners April 3, 2024 17:04
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 7d532a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-wrangler-5494

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5494/npm-package-wrangler-5494

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-wrangler-5494 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-create-cloudflare-5494 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-cloudflare-kv-asset-handler-5494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-miniflare-5494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-cloudflare-pages-shared-5494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8542710396/npm-package-cloudflare-vitest-pool-workers-5494

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.44.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240329.0
workerd 1.20240329.0 1.20240329.0
workerd --version 1.20240329.0 2024-03-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.12%. Comparing base (bf9dca8) to head (7d532a9).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5494      +/-   ##
==========================================
- Coverage   72.13%   72.12%   -0.02%     
==========================================
  Files         331      331              
  Lines       17112    17118       +6     
  Branches     4367     4369       +2     
==========================================
+ Hits        12344    12346       +2     
- Misses       4768     4772       +4     
Files Coverage Δ
packages/wrangler/src/config/index.ts 88.00% <70.00%> (-0.66%) ⬇️

... and 5 files with indirect coverage changes

@penalosa penalosa merged commit a232ccf into main Apr 3, 2024
@penalosa penalosa deleted the penalosa/pages-handle-parsing-errors branch April 3, 2024 17:33
@workers-devprod workers-devprod mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants