Add 'get-bucket-notification-cfg' subcmd for R2#5461
Add 'get-bucket-notification-cfg' subcmd for R2#5461petebacondarwin merged 3 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7e353e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aab752a to
96a76f2
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-wrangler-5461You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5461/npm-package-wrangler-5461Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-wrangler-5461 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-create-cloudflare-5461 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-cloudflare-kv-asset-handler-5461npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-miniflare-5461npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-cloudflare-pages-shared-5461npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8524092101/npm-package-cloudflare-vitest-pool-workers-5461Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
==========================================
+ Coverage 72.15% 72.24% +0.09%
==========================================
Files 326 329 +3
Lines 16853 16976 +123
Branches 4311 4324 +13
==========================================
+ Hits 12160 12265 +105
- Misses 4693 4711 +18
|
13357e6 to
1ebe20f
Compare
There was a problem hiding this comment.
In other commands you are sending metrics events, did you want to do that here too?
There was a problem hiding this comment.
Can you link to an example of what you mean?
There was a problem hiding this comment.
There was a problem hiding this comment.
Not a blocker for this PR, and it is up to you whether to you want to add metrics for these commands.
There was a problem hiding this comment.
Oh, wow, nice, I did not know that was in there. That is actually a great idea but I'm going to make a separate work ticket to do it for all the notification handlers
9f97580 to
b294f61
Compare
1e9bb62 to
7e353e8
Compare
What this PR solves / how to test
Fixes MQ-599.
Author has addressed the following