Skip to content

add helpful logging to --experimental-versions commands#5419

Merged
RamIdeas merged 7 commits intomainfrom
versions-rollback-messaging
Mar 28, 2024
Merged

add helpful logging to --experimental-versions commands#5419
RamIdeas merged 7 commits intomainfrom
versions-rollback-messaging

Conversation

@RamIdeas
Copy link
Copy Markdown
Contributor

@RamIdeas RamIdeas commented Mar 27, 2024 •
edited
Loading

What this PR solves / how to test

This PR adds helpful logging to --experimental-versions commands.

The changes in packages/cli are a refactor and do not effect the output by default but now there are options to override the default formatting.

CR: https://jira.cfdata.org/browse/CR-850334

Author has addressed the following

RamIdeas added 4 commits March 27, 2024 19:57
@RamIdeas
chore: refactor to enable log prefix customisation in cli package
09a7188 
defaults applied keep the output the same as before
we can change the defaults to be more sane in a follow-up after devweek
@RamIdeas
update rollback warning
97144c0
@RamIdeas
add logging after versions upload to instruct users of next commands …
ff74d81 
…to run
@RamIdeas
add changeset
762a0af
@RamIdeas RamIdeas requested a review from a team as a code owner March 27, 2024 20:30
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5f7ecb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5419/npm-package-wrangler-5419

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-create-cloudflare-5419 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-kv-asset-handler-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-miniflare-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-pages-shared-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-vitest-pool-workers-5419

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.26%. Comparing base (7115568) to head (5f7ecb1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5419      +/-   ##
==========================================
+ Coverage   72.19%   72.26%   +0.07%     
==========================================
  Files         322      322              
  Lines       16666    16670       +4     
  Branches     4260     4258       -2     
==========================================
+ Hits        12032    12047      +15     
+ Misses       4634     4623      -11
Files Coverage Δ
packages/wrangler/src/deployments.ts 76.35% <ø> (ø)
packages/wrangler/src/versions/rollback/index.ts 21.73% <0.00%> (ø)
packages/wrangler/src/versions/upload.ts 11.50% <25.00%> (+0.27%) ⬆️

... and 8 files with indirect coverage changes

mrbbot
mrbbot approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very minor non-blocking comments, but feel free to merge.

Comment thread packages/cli/index.ts Outdated
Comment thread packages/wrangler/src/versions/upload.ts Outdated
@RamIdeas RamIdeas merged commit daac6a2 into main Mar 28, 2024
@RamIdeas RamIdeas deleted the versions-rollback-messaging branch March 28, 2024 19:29
@workers-devprod workers-devprod mentioned this pull request Mar 28, 2024
Merged
@lrapoport-cf lrapoport-cf added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 28, 2024
RamIdeas added a commit that referenced this pull request Mar 28, 2024
@RamIdeas
Revert "add helpful logging to --experimental-versions commands (#5419)"
c86ccff 
This reverts commit daac6a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrbbot mrbbot mrbbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ldw-exempt PRs marked with this label can be included in releases during LDW.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RamIdeas @mrbbot @lrapoport-cf