Skip to content

WAFFLE-538 Integrate ratelimits to wrangler dev --local#5403

Merged
penalosa merged 1 commit intocloudflare:mainfrom
oliy:oli/ratelimit
Apr 3, 2024
Merged

WAFFLE-538 Integrate ratelimits to wrangler dev --local#5403
penalosa merged 1 commit intocloudflare:mainfrom
oliy:oli/ratelimit

Conversation

@oliy
Copy link
Copy Markdown
Contributor

@oliy oliy commented Mar 27, 2024 •
edited by mrbbot
Loading

What this PR solves / how to test

Author has addressed the following

@oliy oliy requested a review from a team as a code owner March 27, 2024 06:16
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: de57fa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@irvinebroque irvinebroque requested review from mrbbot and penalosa March 27, 2024 07:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-wrangler-5403

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5403/npm-package-wrangler-5403

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-wrangler-5403 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-create-cloudflare-5403 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-cloudflare-kv-asset-handler-5403
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-miniflare-5403
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-cloudflare-pages-shared-5403
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8510987385/npm-package-cloudflare-vitest-pool-workers-5403

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.42.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240329.0
workerd 1.20240329.0 1.20240329.0
workerd --version 1.20240329.0 2024-03-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.22%. Comparing base (77152f3) to head (de57fa7).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5403      +/-   ##
==========================================
+ Coverage   72.15%   72.22%   +0.06%     
==========================================
  Files         326      326              
  Lines       16853    16858       +5     
  Branches     4311     4313       +2     
==========================================
+ Hits        12160    12175      +15     
+ Misses       4693     4683      -10
Files Coverage Δ
packages/wrangler/src/dev/miniflare.ts 62.93% <40.00%> (+1.25%) ⬆️

... and 6 files with indirect coverage changes

mrbbot
mrbbot reviewed Mar 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for opening this PR. Before we can merge this, we'll need to get some tests and a changeset added. See https://github.com/cloudflare/workers-sdk/blob/main/CONTRIBUTING.md#changesets for more information. You'll also want to format your code by running pnpm prettify in the root of the repo. Functionally, the change looks good though. 👍

@oliy oliy force-pushed the oli/ratelimit branch 4 times, most recently from f1c1467 to 69b19f9 Compare April 1, 2024 16:22
@petebacondarwin petebacondarwin requested a review from mrbbot April 3, 2024 09:05
@irvinebroque
Copy link
Copy Markdown
Contributor

irvinebroque commented Apr 3, 2024

@oliy can merge? get in release?

@oliy
Copy link
Copy Markdown
Contributor Author

oliy commented Apr 3, 2024

Yay! Should be ready now? I don't have merge privileges, so @mrbbot will probably have to do it for me?

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Apr 3, 2024

Does this have to land today? We have just locked main for today's release.
We will be doing another release tomorrow morning.

@penalosa penalosa merged commit 5d6d521 into cloudflare:main Apr 3, 2024
@workers-devprod workers-devprod mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penalosa penalosa Awaiting requested review from penalosa

1 more reviewer

@mrbbot mrbbot mrbbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oliy @irvinebroque @petebacondarwin @mrbbot @penalosa