Skip to content

Adding new Input attribute used for Crowdstrike S2S #1126

Merged
jacobbednarz merged 5 commits intocloudflare:masterfrom
suhrit-cf:master
Nov 18, 2022
Merged

Adding new Input attribute used for Crowdstrike S2S #1126
jacobbednarz merged 5 commits intocloudflare:masterfrom
suhrit-cf:master

Conversation

@suhrit-cf
Copy link
Copy Markdown

@suhrit-cf suhrit-cf commented Nov 9, 2022

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

YES
Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.
LOCALLY

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2022

changelog detected ✅

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.11%. Comparing base (4ddb00c) to head (74d9a1e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files         121      121           
  Lines       11722    11722           
=======================================
  Hits         5874     5874           
  Misses       4565     4565           
  Partials     1283     1283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobbednarz
Copy link
Copy Markdown
Contributor

@suhrit-cf if you can add the changelog, we can get this merged.

@suhrit-cf
Copy link
Copy Markdown
Author

@jacobbednarz done.

@jacobbednarz jacobbednarz merged commit f2353ec into cloudflare:master Nov 18, 2022
@jacobbednarz
Copy link
Copy Markdown
Contributor

thanks!

@github-actions github-actions Bot added this to the v0.55.0 milestone Nov 18, 2022
github-actions Bot pushed a commit that referenced this pull request Nov 18, 2022
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.55.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants