Skip to content

Add hide_user_logs param to AuditLogFilter#1075

Merged
jacobbednarz merged 2 commits intocloudflare:masterfrom
MaggotMouth:add-param-to-audit-log-query
Aug 31, 2022
Merged

Add hide_user_logs param to AuditLogFilter#1075
jacobbednarz merged 2 commits intocloudflare:masterfrom
MaggotMouth:add-param-to-audit-log-query

Conversation

@MaggotMouth
Copy link
Copy Markdown

Description

The API supports filtering on this field for the user as well as the accounts endpoints for AuditLogs.

Has your change been tested?

Test case for AuditLogs has been added.
Automated tests have run successfully (verbosity stripped for brevity):

$ go test
PASS
ok  	github.com/cloudflare/cloudflare-go	0.651s

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

The API supports filtering on this field for the /user as well as the /accounts endpoints for AuditLogs.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2022

changelog detected ✅

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 31, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.06%. Comparing base (e39278e) to head (75c5f81).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   49.94%   50.06%   +0.11%     
==========================================
  Files         115      117       +2     
  Lines       10991    11088      +97     
==========================================
+ Hits         5490     5551      +61     
- Misses       4338     4362      +24     
- Partials     1163     1175      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobbednarz jacobbednarz merged commit 41505e9 into cloudflare:master Aug 31, 2022
@jacobbednarz
Copy link
Copy Markdown
Contributor

thanks for this PR @MaggotMouth 🏆

@github-actions github-actions Bot added this to the v0.50.0 milestone Aug 31, 2022
github-actions Bot pushed a commit that referenced this pull request Aug 31, 2022
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.50.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants