Skip to content

Add support for Email routing#1034

Merged
jacobbednarz merged 9 commits intocloudflare:masterfrom
Cyb3r-Jak3:email-routing
Aug 11, 2022
Merged

Add support for Email routing#1034
jacobbednarz merged 9 commits intocloudflare:masterfrom
Cyb3r-Jak3:email-routing

Conversation

@Cyb3r-Jak3
Copy link
Copy Markdown

Description

Adds support for the email routing APIs
https://api.cloudflare.com/#email-routing---destination-addresses-properties
https://api.cloudflare.com/#email-routing---routing-rules-properties
https://api.cloudflare.com/#email-routing---settings-properties

Has your change been tested?

Unit tests added and all unit tests pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Copy Markdown

changelog detected ✅

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2022

Codecov Report

❌ Patch coverage is 64.57565% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.72%. Comparing base (6c5ea4a) to head (5d89260).

Files with missing lines Patch % Lines
email_routing_rules.go 65.64% 30 Missing and 15 partials ⚠️
email_routing_destination.go 66.25% 18 Missing and 9 partials ⚠️
email_routing_settings.go 60.00% 16 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   49.06%   49.72%   +0.66%     
==========================================
  Files         108      115       +7     
  Lines       10428    10850     +422     
==========================================
+ Hits         5116     5395     +279     
- Misses       4200     4295      +95     
- Partials     1112     1160      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread email_routing_destination.go Outdated
Comment thread email_routing_destination.go
@jacobbednarz jacobbednarz merged commit 161df32 into cloudflare:master Aug 11, 2022
@github-actions github-actions Bot added this to the v0.47.0 milestone Aug 11, 2022
@jacobbednarz
Copy link
Copy Markdown
Contributor

github-actions Bot pushed a commit that referenced this pull request Aug 11, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the email-routing branch August 12, 2022 02:16
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants