http: Fixes for Gin http receiver sample (#905)

dgeorgievski · web-flow · commit 5232986dcdc0 · 2023-06-08T10:43:35.000-04:00
Fixes for prematurely closed #842 PR. Applied all suggested code and doc changes.. Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
diff --git a/samples/http/receiver-gin/README.md b/samples/http/receiver-gin/README.md
@@ -8,8 +8,7 @@ An example of a Gin webframework CloudEvents receiver with a [TektonEvent](https
 Get dependencies
 ```shell
 cd samples/
- go get github.com/gin-gonic/gin
- go get github.com/rs/zerolog/log
+ go get
 
 ```
 
@@ -18,11 +17,11 @@ Run the app
  go run main.go
 ```
 
-Test a CloudEvent
+Send a CloudEvent
 ```shell
 curl -v \
  -H "Ce-Id: e7d95c20-6eb4-4614-946d-27b0ce41c7ff" \
- -H "Ce-Source: /apis///namespaces/dimitar//clone-build-n4qhgl" \
+ -H "Ce-Source: /apis/namespaces/dimitar/clone-build-n4qhgl" \
  -H "Ce-Subject: clone-build-n4qhgl"  \
  -H "Ce-Specversion: 1.0" \
  -H "Ce-Type: dev.tekton.event.pipelinerun.started.v1" \
@@ -39,7 +38,7 @@ Logs output
 Got an Event: Context Attributes,
   specversion: 1.0
   type: dev.tekton.event.pipelinerun.started.v1
-  source: /apis///namespaces/dimitar//clone-build-n4qhgl
+  source: /apis/namespaces/dimitar/clone-build-n4qhgl
   subject: clone-build-n4qhgl
   id: e7d95c20-6eb4-4614-946d-27b0ce41c7ff
   datacontenttype: application/json
diff --git a/samples/http/receiver-gin/main.go b/samples/http/receiver-gin/main.go
@@ -10,7 +10,7 @@ import (
 	"github.com/gin-gonic/gin"
 )
 
-func receiveTektonEvent(event cloudevents.Event) {
+func receive(event cloudevents.Event) {
 	fmt.Printf("Got an Event: %s", event)
 }
 
@@ -23,7 +23,6 @@ func healthz(c *gin.Context) {
 }
 
 func cloudEventsHandler() gin.HandlerFunc {
-
 	return func(c *gin.Context) {
 		p, err := cloudevents.NewHTTP()
 		if err != nil {
@@ -32,7 +31,7 @@ func cloudEventsHandler() gin.HandlerFunc {
 				Msg("Failed to create protocol")
 		}
 
-		ceh, err := cloudevents.NewHTTPReceiveHandler(c, p, receiveTektonEvent)
+		ceh, err := cloudevents.NewHTTPReceiveHandler(c, p, receive)
 		if err != nil {
 			log.Fatal().
 				Err(err).
@@ -44,7 +43,6 @@ func cloudEventsHandler() gin.HandlerFunc {
 }
 
 func main() {
-
 	r := gin.Default()
 	r.SetTrustedProxies(nil)
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import (`
`10`	`10`	`"github.com/gin-gonic/gin"`
`11`	`11`	`)`
`12`	`12`
`13`		`-func receiveTektonEvent(event cloudevents.Event) {`
	`13`	`+func receive(event cloudevents.Event) {`
`14`	`14`	`fmt.Printf("Got an Event: %s", event)`
`15`	`15`	`}`
`16`	`16`
`@@ -23,7 +23,6 @@ func healthz(c *gin.Context) {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`func cloudEventsHandler() gin.HandlerFunc {`
`26`		`-`
`27`	`26`	`return func(c *gin.Context) {`
`28`	`27`	`p, err := cloudevents.NewHTTP()`
`29`	`28`	`if err != nil {`
`@@ -32,7 +31,7 @@ func cloudEventsHandler() gin.HandlerFunc {`
`32`	`31`	`Msg("Failed to create protocol")`
`33`	`32`	`}`
`34`	`33`
`35`		`- ceh, err := cloudevents.NewHTTPReceiveHandler(c, p, receiveTektonEvent)`
	`34`	`+ ceh, err := cloudevents.NewHTTPReceiveHandler(c, p, receive)`
`36`	`35`	`if err != nil {`
`37`	`36`	`log.Fatal().`
`38`	`37`	`Err(err).`
`@@ -44,7 +43,6 @@ func cloudEventsHandler() gin.HandlerFunc {`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`func main() {`
`47`		`-`
`48`	`46`	`r := gin.Default()`
`49`	`47`	`r.SetTrustedProxies(nil)`
`50`	`48`