fix: Prevent nil dereference in `pr view`. #8566

octo · 2024-01-11T22:08:56Z

The API may return a null project, maybe related to "legacy projects". This is translated to a nil pointer in Go. When accessing project.Column, the nil pointer was dereferenced, causing a segmentation fault.

To reproduce, run the following command:

$ gh pr view 3481 -R collectd/collectd

The API may return a `null` project, maybe related to "legacy projects". This is translated to a nil pointer in Go. When accessing `project.Column`, the nil pointer was dereferenced, causing a segmentation fault.

cliAutomation · 2024-01-11T22:09:07Z

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

samcoe · 2024-01-12T18:47:35Z

@octo Thanks for the contribution. Do you have a public repo in which this is reproducible? While we can handle this case in gh it is probably something the API team would also want to address on their side.

octo · 2024-01-12T18:50:50Z

@samcoe Yeah, collectd/collectd#3481 triggers this, for example.

williammartin · 2024-01-15T13:10:52Z

Running gh pr view 3481 -R collectd/collectd seems normal to me. This is what I see:

strbuf: Library that implements printing to a dynamically allocated buffer. #3481
Merged • octo wants to merge 8 commits into collectd-6.0 from strbuf • about 3 years ago
+646 -34 • No checks
Reviewers: igorpeshansky (Commented), mrunge (Approved), sunkuranganath (Requested)
Labels: Feature
Projects: collectd 6 (Done)
Milestone: 6.0


  I'm planning on using this code to build the string representation of a label based metric. This certainly will have
  uses all throughout the daemon though. Looking for "ADD" or "ADDF" macros should uncover places that might benefit
  from this code.

  ChangeLog: collectd: The  strbuf  utility library has been added. It simplifies building strings iteratively.


———————— Not showing 6 comments ————————


igorpeshansky commented (Contributor) • Jul 17, 2020 • Newest comment

  A bit late to the party, but LGTM.


Use --comments to view the full conversation
View this pull request on GitHub: https://github.com/collectd/collectd/pull/3481

What do you see @octo ?

octo · 2024-01-15T13:28:17Z

@williammartin I'm getting:

$ gh pr view 3481 -R collectd/collectd
strbuf: Library that implements printing to a dynamically allocated buffer. #3481
Merged ? octo wants to merge 8 commits into collectd-6.0 from strbuf ? about 3 years ago
+646 -34 ? No checks
Reviewers: igorpeshansky (Commented), mrunge (Approved), sunkuranganath (Requested)
Labels: Feature
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1086524]

goroutine 1 [running]:
github.com/cli/cli/v2/pkg/cmd/pr/view.prProjectList({{0xc0004cc280, 0x20}, 0xd99, {0xc000900280, 0x4b}, {0xc000b00af4, 0x6}, 0x0, {0xc000afd200, 0x2e}, ...})
        github.com/cli/cli/v2/pkg/cmd/pr/view/view.go:405 +0xc4
github.com/cli/cli/v2/pkg/cmd/pr/view.printHumanPrPreview(0xc0005929c0, 0xc00028f500)
        github.com/cli/cli/v2/pkg/cmd/pr/view/view.go:217 +0xb7f
github.com/cli/cli/v2/pkg/cmd/pr/view.viewRun(0xc0005929c0)
        github.com/cli/cli/v2/pkg/cmd/pr/view/view.go:124 +0x386
github.com/cli/cli/v2/pkg/cmd/pr/view.NewCmdView.func1(0xc0006da300?, {0xc0008303c0, 0x1, 0x3?})
        github.com/cli/cli/v2/pkg/cmd/pr/view/view.go:68 +0x165
github.com/spf13/cobra.(*Command).execute(0xc0006da300, {0xc000830390, 0x3, 0x3})
        github.com/spf13/cobra/command.go:916 +0x862
github.com/spf13/cobra.(*Command).ExecuteC(0xc00029e600)
        github.com/spf13/cobra/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).ExecuteContextC(...)
        github.com/spf13/cobra/command.go:977
main.mainRun()
        github.com/cli/cli/v2/cmd/gh/main.go:220 +0xde5
main.main()
        github.com/cli/cli/v2/cmd/gh/main.go:50 +0x19

~~Sounds to me like the nil is only returned when you have certain permissions on the repository or organization.~~

The "collectd 6" project you're seeing is the value I'd expect to see.

williammartin · 2024-01-15T13:34:51Z

Thanks. Is it possible for you to provide the contents of GH_DEBUG=api gh pr view 3481 -R collectd/collectd so I can see the exact requests and responses sent?

octo · 2024-01-15T13:42:58Z

The attached file was generated with:

GH_DEBUG=api gh pr view 3481 -R collectd/collectd 2>&1 | tee issue-8566.txt

issue-8566.txt

williammartin · 2024-01-15T14:13:18Z

As you know, here's what you get in the API response:

...
        "projectCards": {
          "nodes": [
            null
          ],
          "totalCount": 1
       },
...

And here's what I see:

...
        "projectCards": {
          "nodes": [
            {
              "project": {
                "name": "collectd 6"
              },
              "column": {
                "name": "Done"
              }
            }
          ],
          "totalCount": 1
        },
...

But why on earth would I have permissions to see this and you wouldn't 🤔

Like @samcoe, I'm not opposed to adding something to the CLI to resolve this but I feel a bit nervous without understanding what's actually going on here.

williammartin · 2024-01-15T14:14:29Z

How are you authenticating with gh? Can you share the output of gh auth status?

octo · 2024-01-15T14:16:57Z

Here you go:

$ gh auth status
github.com
  ? Logged in to github.com as octo (/home/octo/.config/gh/hosts.yml)
  ? Git operations for github.com configured to use ssh protocol.
  ? Token: github_pat_********

williammartin · 2024-01-15T14:22:59Z

I should have guessed! github_pat_ prefix indicates that you are using a fine grained access token, which is nearly always the cause of weird permissions related things. If you go to https://github.com/settings/tokens?type=beta, click on the token you are using, can you share the permissions you have set, for example, here's a screenshot of some random fine grained PAT I have:

octo · 2024-01-15T14:40:17Z

Here's a screenshot:

Notably this is missing the "Pull requests" repository permission.

williammartin · 2024-01-15T15:30:45Z

Yeh so this is easily reproducible using a fine grained PAT for public repositories with minimal permissions. The thing is that when you create a fine-grained PAT you associate it with a resource owner, for example in your case, the resource owner is your account (hence why it has a section for Account Permissions).

As the classic project board is owned by the collectd org, I think when creating the PAT you need to select collectd as the resource owner and then under a new heading Organization Settings you should see an entry for projects:

All that said, you should still be able to use the CLI without this permission without it blowing up. I'm not sure whether the platform should be returning [] or null here but I'd be surprised if the current behaviour of returning null is considered a bug because the code that backs this looks like a standard abstraction shared across the API.

What probably is a bug is the fact that totalCount isn't permission checked in the same way.

octo · 2024-01-15T16:03:28Z

Gotcha! Thanks for the detailed explanation 😁

samcoe

@octo Thanks for addressing this and adding the test!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.124.0` -> `v4.128.0` | | [cli/cli](https://togithub.com/cli/cli) | minor | `v2.42.1` -> `v2.43.1` | | [junegunn/fzf](https://togithub.com/junegunn/fzf) | patch | `0.46.0` -> `0.46.1` | | [marcosnils/bin](https://togithub.com/marcosnils/bin) | patch | `v0.17.2` -> `v0.17.3` | | [nektos/act](https://togithub.com/nektos/act) | patch | `v0.2.57` -> `v0.2.59` | | [sigstore/cosign](https://togithub.com/sigstore/cosign) | patch | `v2.2.2` -> `v2.2.3` | | [simulot/immich-go](https://togithub.com/simulot/immich-go) | minor | `0.9.12` -> `0.10.0` | | [wagoodman/dive](https://togithub.com/wagoodman/dive) | minor | `v0.11.0` -> `v0.12.0` | | [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor | `v0.169.0` -> `v0.170.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.128.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.128.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.127.1...v4.128.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.128.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.128.0) | aquaproj/aqua-registry@v4.127.1...v4.128.0 #### 🎉 New Packages [#19594](https://togithub.com/aquaproj/aqua-registry/issues/19594) [gitea.com/gitea/tea](https://gitea.com/gitea/tea): Command line tool to interact with Gitea servers [#19593](https://togithub.com/aquaproj/aqua-registry/issues/19593) [gitlab.com/gitlab-org/cli](https://gitlab.com/gitlab-org/cli): A GitLab CLI tool bringing GitLab to your command line > \[!NOTE] > Update aqua-renovate-config to 2.0.0 or newer > To update these packages by Renovate, please update aqua-renovate-config to 2.0.0 or newer > https://github.com/aquaproj/aqua-renovate-config/releases/tag/2.0.0 > \[!WARNING] > These packages have several restriction at the moment. > > - `aqua g` can't get the version, so you need to edit the version manually > - `aqua update` doesn't support these packages ### [`v4.127.1`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.127.1) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.127.0...v4.127.1) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.127.1) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.127.1) | aquaproj/aqua-registry@v4.127.0...v4.127.1 #### Fixes [#19544](https://togithub.com/aquaproj/aqua-registry/issues/19544) eza-community/eza: Support darwin and windows/arm64 using cargo > \[!WARNING] > To support darwin and windows/arm64, aqua >= v2.23.0 is required [#19568](https://togithub.com/aquaproj/aqua-registry/issues/19568) sharkdp/bat: Regenerate config by `cmdx s` [#19591](https://togithub.com/aquaproj/aqua-registry/issues/19591) swaggo/swag: Follow up changes of swag v1.16.3 ### [`v4.127.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.127.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.126.0...v4.127.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.127.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.127.0) | aquaproj/aqua-registry@v4.126.0...v4.127.0 #### 🎉 New Packages [#19518](https://togithub.com/aquaproj/aqua-registry/issues/19518) [crates.io/eza](https://crates.io/crates/eza): A modern replacement for ls [@Omochice](https://togithub.com/Omochice) > \[!NOTE] > We will merge this package with `eza-community/eza`. > Now we can't merge these packages due to the technical issue[https://github.com/aquaproj/aqua/issues/2649](https://togithub.com/aquaproj/aqua/issues/2649)49 #### Fixes [#19530](https://togithub.com/aquaproj/aqua-registry/issues/19530) eza-community/eza: Regenerate config by `cmdx s` [#19533](https://togithub.com/aquaproj/aqua-registry/issues/19533) okta/okta-aws-cli: Follow up changes of okta-aws-cli v2.0.1 #### 🎉 New Contributors Thank you for your contribution! [@Omochice](https://togithub.com/Omochice) [#19518](https://togithub.com/aquaproj/aqua-registry/issues/19518) ### [`v4.126.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.126.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.125.1...v4.126.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.126.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.126.0) | aquaproj/aqua-registry@v4.125.1...v4.126.0 #### 🎉 New Packages [#13513](https://togithub.com/aquaproj/aqua-registry/issues/13513) [#19465](https://togithub.com/aquaproj/aqua-registry/issues/19465) [loft-sh/devpod](https://togithub.com/loft-sh/devpod): Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker [@CrystalMethod](https://togithub.com/CrystalMethod) ### [`v4.125.1`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.125.1) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.125.0...v4.125.1) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.125.1) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.125.1) | aquaproj/aqua-registry@v4.125.0...v4.125.1 #### Fixes [#19450](https://togithub.com/aquaproj/aqua-registry/issues/19450) lxc/incus: Follow up changes of incus v0.5.1 [#19447](https://togithub.com/aquaproj/aqua-registry/issues/19447) kool-dev/kool: Follow up changes of kool 3.0.0 [#19442](https://togithub.com/aquaproj/aqua-registry/issues/19442) mattn/zig-update: Follow up changes of zig-update [#19439](https://togithub.com/aquaproj/aqua-registry/issues/19439) cli/cli: Disable rosetta2 and use files for darwin/arm64 ### [`v4.125.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.125.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.124.0...v4.125.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.125.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.125.0) | aquaproj/aqua-registry@v4.124.0...v4.125.0 #### 🎉 New Packages [#19388](https://togithub.com/aquaproj/aqua-registry/issues/19388) [erebe/wstunnel](https://togithub.com/erebe/wstunnel): Tunnel all your traffic over Websocket or HTTP2 - Bypass firewalls/DPI [@CrystalMethod](https://togithub.com/CrystalMethod) </details> <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.43.1`](https://togithub.com/cli/cli/releases/tag/v2.43.1): GitHub CLI 2.43.1 [Compare Source](https://togithub.com/cli/cli/compare/v2.43.0...v2.43.1) #### What's Changed - Fix label create regression in v2.43.0 by [@williammartin](https://togithub.com/williammartin) in [https://github.com/cli/cli/pull/8653](https://togithub.com/cli/cli/pull/8653) **Full Changelog**: cli/cli@v2.43.0...v2.43.1 ### [`v2.43.0`](https://togithub.com/cli/cli/releases/tag/v2.43.0): GitHub CLI 2.43.0 [Compare Source](https://togithub.com/cli/cli/compare/v2.42.1...v2.43.0) #### Special note With this release, the GitHub CLI team sees [@samcoe](https://togithub.com/samcoe) off to new adventures beyond GitHub! 😿 Sam has been an amazing maintainer and colleague who has helped so many people adopt `gh` while trying to connect with the community regarding its needs. There will forever be a Sam-shaped hole no one can fill but hope he continues to be a part wherever his whirlwind journey takes him! ❤️ #### What's Changed - Remove project JSON formatting objects by [@heaths](https://togithub.com/heaths) in [https://github.com/cli/cli/pull/8541](https://togithub.com/cli/cli/pull/8541) - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8467](https://togithub.com/cli/cli/pull/8467) - build(deps): bump actions/download-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8466](https://togithub.com/cli/cli/pull/8466) - Add option --json for gh variable list by [@w1mvy](https://togithub.com/w1mvy) in [https://github.com/cli/cli/pull/8516](https://togithub.com/cli/cli/pull/8516) - Add `--json` export flag for release list by [@v1v](https://togithub.com/v1v) in [https://github.com/cli/cli/pull/8474](https://togithub.com/cli/cli/pull/8474) - 📝 (search/repos) add usage tips for --archived=false by [@shion1305](https://togithub.com/shion1305) in [https://github.com/cli/cli/pull/8391](https://togithub.com/cli/cli/pull/8391) - fix: Prevent nil dereference in `pr view`. by [@octo](https://togithub.com/octo) in [https://github.com/cli/cli/pull/8566](https://togithub.com/cli/cli/pull/8566) - Fix some typos raised by codespell by [@fpistm](https://togithub.com/fpistm) in [https://github.com/cli/cli/pull/8589](https://togithub.com/cli/cli/pull/8589) - Add force flag to setup-git command by [@rajhawaldar](https://togithub.com/rajhawaldar) in [https://github.com/cli/cli/pull/8552](https://togithub.com/cli/cli/pull/8552) - build(deps): bump actions/cache from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8594](https://togithub.com/cli/cli/pull/8594) - Feature: output URL for newly created repo by [@leevic31](https://togithub.com/leevic31) in [https://github.com/cli/cli/pull/8574](https://togithub.com/cli/cli/pull/8574) - Update Arch repo to \[extra] by [@Xeonacid](https://togithub.com/Xeonacid) in [https://github.com/cli/cli/pull/8607](https://togithub.com/cli/cli/pull/8607) - build(deps): bump microsoft/setup-msbuild from 1.3.1 to 1.3.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8629](https://togithub.com/cli/cli/pull/8629) - fix(pr create): clarify refspec to push to correct branch in the event of a conflicting tag by [@arunsathiya](https://togithub.com/arunsathiya) in [https://github.com/cli/cli/pull/8618](https://togithub.com/cli/cli/pull/8618) - Send activity signals during non-interactive codespace SSH command by [@dmgardiner25](https://togithub.com/dmgardiner25) in [https://github.com/cli/cli/pull/8639](https://togithub.com/cli/cli/pull/8639) - Upgrade cli/go-gh to v2.5.0 for home-manager fix by [@andyfeller](https://togithub.com/andyfeller) in [https://github.com/cli/cli/pull/8647](https://togithub.com/cli/cli/pull/8647) #### New Contributors - [@w1mvy](https://togithub.com/w1mvy) made their first contribution in [https://github.com/cli/cli/pull/8516](https://togithub.com/cli/cli/pull/8516) - [@v1v](https://togithub.com/v1v) made their first contribution in [https://github.com/cli/cli/pull/8474](https://togithub.com/cli/cli/pull/8474) - [@octo](https://togithub.com/octo) made their first contribution in [https://github.com/cli/cli/pull/8566](https://togithub.com/cli/cli/pull/8566) - [@fpistm](https://togithub.com/fpistm) made their first contribution in [https://github.com/cli/cli/pull/8589](https://togithub.com/cli/cli/pull/8589) - [@leevic31](https://togithub.com/leevic31) made their first contribution in [https://github.com/cli/cli/pull/8574](https://togithub.com/cli/cli/pull/8574) - [@Xeonacid](https://togithub.com/Xeonacid) made their first contribution in [https://github.com/cli/cli/pull/8607](https://togithub.com/cli/cli/pull/8607) **Full Changelog**: cli/cli@v2.42.1...v2.43.0 </details> <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.46.1`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#0461) [Compare Source](https://togithub.com/junegunn/fzf/compare/0.46.0...0.46.1) - Bug fixes and improvements - Fixed Windows binaries - Downgraded Go version to 1.20 to support older versions of Windows - https://tip.golang.org/doc/go1.21#windows - Updated [rivo/uniseg](https://togithub.com/rivo/uniseg) dependency to v0.4.6 </details> <details> <summary>marcosnils/bin (marcosnils/bin)</summary> ### [`v0.17.3`](https://togithub.com/marcosnils/bin/releases/tag/v0.17.3) [Compare Source](https://togithub.com/marcosnils/bin/compare/v0.17.2...v0.17.3) #### Changelog - [`9da887d`](https://togithub.com/marcosnils/bin/commit/9da887d) allow to install and remove binaries in relative paths ([#186](https://togithub.com/marcosnils/bin/issues/186)) </details> <details> <summary>nektos/act (nektos/act)</summary> ### [`v0.2.59`](https://togithub.com/nektos/act/releases/tag/v0.2.59) [Compare Source](https://togithub.com/nektos/act/compare/v0.2.58...v0.2.59) #### Changelog ##### New Features - [`12c0c42`](https://togithub.com/nektos/act/commit/12c0c42) feat: correctly use the xdg library, which has the side effect to fix the config survey ([#2195](https://togithub.com/nektos/act/issues/2195)) ##### Other - [`b7a8145`](https://togithub.com/nektos/act/commit/b7a8145) chore: bump VERSION to 0.2.59 ### [`v0.2.58`](https://togithub.com/nektos/act/releases/tag/v0.2.58) [Compare Source](https://togithub.com/nektos/act/compare/v0.2.57...v0.2.58) #### Changelog ##### New Features - [`f055d4a`](https://togithub.com/nektos/act/commit/f055d4a) feat: support offline mode ([#2128](https://togithub.com/nektos/act/issues/2128)) - [`f7a846d`](https://togithub.com/nektos/act/commit/f7a846d) feat: cli option to enable the new action cache ([#1954](https://togithub.com/nektos/act/issues/1954)) ##### Bug fixes - [`054caec`](https://togithub.com/nektos/act/commit/054caec) fix: use correct path to toolcache ([#1494](https://togithub.com/nektos/act/issues/1494)) - [`5e0d29d`](https://togithub.com/nektos/act/commit/5e0d29d) fix: improve warning about remote not found ([#2169](https://togithub.com/nektos/act/issues/2169)) - [`6dd6725`](https://togithub.com/nektos/act/commit/6dd6725) fix: improve new-action-cache fetch failure error ([#2172](https://togithub.com/nektos/act/issues/2172)) - [`09d4b5d`](https://togithub.com/nektos/act/commit/09d4b5d) fix: subpath actions via new artifact cache ([#2170](https://togithub.com/nektos/act/issues/2170)) - [`a6ec2c1`](https://togithub.com/nektos/act/commit/a6ec2c1) fix: improve action not found error ([#2171](https://togithub.com/nektos/act/issues/2171)) - [`6091094`](https://togithub.com/nektos/act/commit/6091094) fix: write default config in XDG config dir to avoid cluttering the HOME directory by default ([#2140](https://togithub.com/nektos/act/issues/2140)) - [`7f7d84b`](https://togithub.com/nektos/act/commit/7f7d84b) fix: match cache `restore-keys` in creation reverse order ([#2153](https://togithub.com/nektos/act/issues/2153)) ##### Other - [`3ed38d8`](https://togithub.com/nektos/act/commit/3ed38d8) chore: bump VERSION to 0.2.58 - [`0dbf44c`](https://togithub.com/nektos/act/commit/0dbf44c) build(deps): bump github.com/opencontainers/runc from 1.1.7 to 1.1.12 ([#2187](https://togithub.com/nektos/act/issues/2187)) - [`6dcf9bc`](https://togithub.com/nektos/act/commit/6dcf9bc) build(deps): bump github.com/moby/buildkit from 0.11.5 to 0.12.5 ([#2188](https://togithub.com/nektos/act/issues/2188)) - [`df61c7f`](https://togithub.com/nektos/act/commit/df61c7f) build(deps): bump github.com/containerd/containerd from 1.6.19 to 1.6.26 ([#2189](https://togithub.com/nektos/act/issues/2189)) - [`36e0261`](https://togithub.com/nektos/act/commit/36e0261) build(deps): bump github.com/opencontainers/image-spec ([#2167](https://togithub.com/nektos/act/issues/2167)) - [`46dc2ff`](https://togithub.com/nektos/act/commit/46dc2ff) build(deps): bump github.com/moby/buildkit from 0.12.4 to 0.12.5 ([#2186](https://togithub.com/nektos/act/issues/2186)) - [`5a80a04`](https://togithub.com/nektos/act/commit/5a80a04) refactor: filecollector into new package ([#2174](https://togithub.com/nektos/act/issues/2174)) - [`4ca35d2`](https://togithub.com/nektos/act/commit/4ca35d2) build(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 ([#2175](https://togithub.com/nektos/act/issues/2175)) - [`424fd5e`](https://togithub.com/nektos/act/commit/424fd5e) refactor(cmd/root): simplify `parseEnvs` ([#2162](https://togithub.com/nektos/act/issues/2162)) - [`6a8c42a`](https://togithub.com/nektos/act/commit/6a8c42a) Add containerd's normalized architectures to archMapper ([#2168](https://togithub.com/nektos/act/issues/2168)) - [`c215e08`](https://togithub.com/nektos/act/commit/c215e08) build(deps): bump megalinter/megalinter from 7.7.0 to 7.8.0 ([#2164](https://togithub.com/nektos/act/issues/2164)) - [`8072a00`](https://togithub.com/nektos/act/commit/8072a00) WorkflowDispatchConfig supports multiple yaml node kinds ([#2123](https://togithub.com/nektos/act/issues/2123)) - [`15bb54f`](https://togithub.com/nektos/act/commit/15bb54f) build(deps): bump actions/upload-artifact from 3 to 4 ([#2133](https://togithub.com/nektos/act/issues/2133)) - [`cd40f3f`](https://togithub.com/nektos/act/commit/cd40f3f) ci: automatic merge PRs created by a maintainer and approved by 1 other maintainer ([#2156](https://togithub.com/nektos/act/issues/2156)) - [`adbe229`](https://togithub.com/nektos/act/commit/adbe229) Add support for NetBSD ([#2023](https://togithub.com/nektos/act/issues/2023)) - [`96d6cf8`](https://togithub.com/nektos/act/commit/96d6cf8) build(deps): bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 ([#2149](https://togithub.com/nektos/act/issues/2149)) - [`ef5746b`](https://togithub.com/nektos/act/commit/ef5746b) build(deps): bump golang.org/x/term from 0.15.0 to 0.16.0 ([#2148](https://togithub.com/nektos/act/issues/2148)) </details> <details> <summary>sigstore/cosign (sigstore/cosign)</summary> ### [`v2.2.3`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v223) [Compare Source](https://togithub.com/sigstore/cosign/compare/v2.2.2...v2.2.3) #### Bug Fixes - Fix race condition on verification with multiple signatures attached to image ([#3486](https://togithub.com/sigstore/cosign/issues/3486)) - fix(clean): Fix clean cmd for private registries ([#3446](https://togithub.com/sigstore/cosign/issues/3446)) - Fixed BYO PKI verification ([#3427](https://togithub.com/sigstore/cosign/issues/3427)) #### Features - Allow for option in cosign attest and attest-blob to upload attestation as supported in Rekor ([#3466](https://togithub.com/sigstore/cosign/issues/3466)) - Add support for OpenVEX predicate type ([#3405](https://togithub.com/sigstore/cosign/issues/3405)) #### Documentation - Resolves [#3088](https://togithub.com/sigstore/cosign/issues/3088): `version` sub-command expected behaviour documentation and testing ([#3447](https://togithub.com/sigstore/cosign/issues/3447)) - add examples for cosign attach signature cmd ([#3468](https://togithub.com/sigstore/cosign/issues/3468)) #### Misc - Remove CertSubject function ([#3467](https://togithub.com/sigstore/cosign/issues/3467)) - Use local rekor and fulcio instances in e2e tests ([#3478](https://togithub.com/sigstore/cosign/issues/3478)) #### Contributors - aalsabag - Bob Callaway - Carlos Tadeu Panato Junior - Colleen Murphy - Hayden B - Mukuls77 - Omri Bornstein - Puerco - vivek kumar sahu </details> <details> <summary>simulot/immich-go (simulot/immich-go)</summary> ### [`v0.10.0`](https://togithub.com/simulot/immich-go/releases/tag/0.10.0) [Compare Source](https://togithub.com/simulot/immich-go/compare/0.9.12...0.10.0) #### Changelog - [`0d8a166`](https://togithub.com/simulot/immich-go/commit/0d8a166) Merge branch 'main' into [#135](https://togithub.com/simulot/immich-go/issues/135)-feat--use-the-searchAssets-API-to-workaroud-server's-timeout - [`13e6ba4`](https://togithub.com/simulot/immich-go/commit/13e6ba4) Update readme.md ([#137](https://togithub.com/simulot/immich-go/issues/137)) - [`815ef70`](https://togithub.com/simulot/immich-go/commit/815ef70) fix: [#131](https://togithub.com/simulot/immich-go/issues/131) panic syntax error in pattern - [`a51e022`](https://togithub.com/simulot/immich-go/commit/a51e022) fix: [#135](https://togithub.com/simulot/immich-go/issues/135) use the searchAssets API to workaround server's timeout </details> <details> <summary>wagoodman/dive (wagoodman/dive)</summary> ### [`v0.12.0`](https://togithub.com/wagoodman/dive/releases/tag/v0.12.0) [Compare Source](https://togithub.com/wagoodman/dive/compare/v0.11.0...v0.12.0) ### Changelog #### [v0.12.0](https://togithub.com/wagoodman/dive/tree/v0.12.0) (2024-02-02) [Full Changelog](https://togithub.com/wagoodman/dive/compare/v0.11.0...v0.12.0) ##### Added Features - Can we do docker layer wise scan for vulnerability detection \[[Issue #465](https://togithub.com/wagoodman/dive/issues/465)] - How to use Dive in gitlab CI Securely? \[[Issue #493](https://togithub.com/wagoodman/dive/issues/493)] ##### Bug Fixes - Dive always fail when trying to fetch local image \[[Issue #462](https://togithub.com/wagoodman/dive/issues/462)] - Unable to analyze the image using dive (Docker 25+ compatibility) \[[Issue #498](https://togithub.com/wagoodman/dive/issues/498)] \[[PR #500](https://togithub.com/wagoodman/dive/pull/500)] \[[tbroyer](https://togithub.com/tbroyer)] ##### Additional Changes - Bump to more recent go version, remove no longer required overrides \[[PR #461](https://togithub.com/wagoodman/dive/pull/461)] \[[SuperSandro2000](https://togithub.com/SuperSandro2000)] - docs: Adds instructions for snap installation \[[PR #484](https://togithub.com/wagoodman/dive/pull/484)] \[[gruyaume](https://togithub.com/gruyaume)] - DIVE_VERSION does not need to be exported \[[PR #492](https://togithub.com/wagoodman/dive/pull/492)] \[[ReneNyffenegger](https://togithub.com/ReneNyffenegger)] - fix(sec): upgrade golang.org/x/net to 0.17.0 \[[PR #503](https://togithub.com/wagoodman/dive/pull/503)] \[[suguds](https://togithub.com/suguds)] </details> <details> <summary>weaveworks/eksctl (weaveworks/eksctl)</summary> ### [`v0.170.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.170.0): eksctl 0.170.0 (permalink) [Compare Source](https://togithub.com/weaveworks/eksctl/compare/0.169.0-rc.0...0.170.0-rc.0) ### Release v0.170.0 #### 🚀 Features - Add support for Access Entry type ([#7522](https://togithub.com/weaveworks/eksctl/issues/7522)) #### 🎯 Improvements - Skip draining managed nodegroups when deleting cluster ([#7515](https://togithub.com/weaveworks/eksctl/issues/7515)) - Expand Karpenter settings.aws block to settings for v0.33.0 and greater ([#7503](https://togithub.com/weaveworks/eksctl/issues/7503)) #### 📝 Documentation - docs(fargate): eksctl update command is deprecated, use upgrade instead ([#7517](https://togithub.com/weaveworks/eksctl/issues/7517)) #### Acknowledgments The eksctl maintainers would like to sincerely thank: [@skl](https://togithub.com/skl) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: Prevent nil dereference in pr view.

424368c

The API may return a `null` project, maybe related to "legacy projects". This is translated to a nil pointer in Go. When accessing `project.Column`, the nil pointer was dereferenced, causing a segmentation fault.

octo requested a review from a team as a code owner January 11, 2024 22:08

octo requested review from williammartin and removed request for a team January 11, 2024 22:08

cliAutomation added the external pull request originating outside of the CLI core team label Jan 11, 2024

samcoe approved these changes Jan 17, 2024

View reviewed changes

samcoe enabled auto-merge (squash) January 17, 2024 22:03

samcoe merged commit 7164f6e into cli:trunk Jan 17, 2024

octo deleted the pr-view-segfault branch January 19, 2024 20:28

arunsathiya mentioned this pull request Jan 24, 2024

fix(pr create): clarify refspec to push to correct branch in the event of a conflicting tag #8618

Merged

BrewTestBot mentioned this pull request Jan 31, 2024

gh 2.43.0 Homebrew/homebrew-core#161419

Closed

fix: Prevent nil dereference in pr view. #8566

fix: Prevent nil dereference in pr view. #8566

Uh oh!

Conversation

octo commented Jan 11, 2024

Uh oh!

cliAutomation commented Jan 11, 2024

Uh oh!

samcoe commented Jan 12, 2024

Uh oh!

octo commented Jan 12, 2024

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

octo commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

octo commented Jan 15, 2024

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

octo commented Jan 15, 2024

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

octo commented Jan 15, 2024

Uh oh!

williammartin commented Jan 15, 2024

Uh oh!

octo commented Jan 15, 2024

Uh oh!

samcoe left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: Prevent nil dereference in `pr view`. #8566

fix: Prevent nil dereference in `pr view`. #8566

octo commented Jan 15, 2024 •

edited

Loading