Add force flag to setup-git command #8552

rajhawaldar · 2024-01-10T02:31:58Z

williammartin

Thanks for picking this up. I know you put some work into the other one and then we decided not to proceed but it was actually very useful since when I read the code it seemed tricky which gave me the idea to simplify things with --force!

williammartin · 2024-01-10T15:10:14Z

pkg/cmd/auth/setupgit/setupgit_test.go

 			expectedErrOut: "You are not logged into any GitHub hosts. Run gh auth login to authenticate.\n",
 		},
+		{
+			name: "if no hostname is specified, the force flag will be ignored.",


I'd like this to be an error, it's a user mistake if they provide --force without --hostname and we should let them know.

williammartin · 2024-01-10T15:10:54Z

pkg/cmd/auth/setupgit/setupgit_test.go

 			expectedErrOut: "",
 		},
+		{
+			name: "add credential helper for unknown host",


Please repeat this test with no hosts, it will currently fail but it should work.

Doesn't look like this was resolved.

williammartin · 2024-01-10T15:11:43Z

pkg/cmd/auth/setupgit/setupgit_test.go

+		{
+			name: "add credential helper for unknown host",
+			opts: &SetupGitOptions{
+				Hostname: "foo",


I know foo exists in another place but I'd prefer if you use something like ghe.io here. It's a bit more descriptive for the test.

pkg/cmd/auth/setupgit/setupgit_test.go

williammartin

Thanks for your continued work on this.

williammartin · 2024-01-15T12:55:07Z

pkg/cmd/auth/setupgit/setupgit_test.go

+		},
+		{
+			name: "setup credential helper for unknown host",
+			opts: &SetupGitOptions{},


This test doesn't seem to do anything?

I suspect you misunderstood my comment above about having no hosts (https://github.com/cli/cli/pull/8552/files#r1447519598)

The idea here is that your implementation will only work if there is at least one host in the hosts file, but it should work with no hosts in the hosts file.

Specifically, here's the test that needs to pass:

{ name: "when the force flag is provided, it sets up the credential helper even if there are no known hosts", opts: &SetupGitOptions{ Hostname: "ghe.io", Force: true, }, expectedHostsSetup: []string{"ghe.io"}, },

I apologies for misreading your comment. Hopefully, The new code changes will address all open issues.

pkg/cmd/auth/setupgit/setupgit_test.go

williammartin · 2024-01-15T12:58:48Z

pkg/cmd/auth/setupgit/setupgit_test.go

 			expectedErrOut: "",
 		},
+		{
+			name: "add credential helper for unknown host",


Doesn't look like this was resolved.

williammartin · 2024-01-15T13:03:42Z

pkg/cmd/auth/setupgit/setupgit.go

 	stderr := opts.IO.ErrOut
 	cs := opts.IO.ColorScheme()
-
+	if opts.Force && opts.Hostname == "" {


Most of the times when we do flag validation, we do it in the cobra related code, in the RunE and then we return a cmdutil.FlagErrorf

See https://github.com/cli/cli/blob/trunk/pkg/cmd/alias/delete/delete.go#L36 for an example

This was something new for me 👍

williammartin · 2024-01-15T13:04:59Z

pkg/cmd/auth/setupgit/setupgit.go

 	}

 	cmd.Flags().StringVarP(&opts.Hostname, "hostname", "h", "", "The hostname to configure git for")
+	cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Add credential helper for unknown host")


Suggested change

cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Add credential helper for unknown host")

cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Force setup even if the host is not known. Must be used in conjunction with `--hostname`")

pkg/cmd/auth/setupgit/setupgit_test.go

williammartin · 2024-01-18T12:15:57Z

pkg/cmd/auth/setupgit/setupgit.go

 	cs := opts.IO.ColorScheme()

+	// If a hostname was provided, we'll set up just that one
+	if opts.Hostname != "" {


I noticed in the existing code that --hostname without --force would return with different errors depending on whether there were known hosts or not, and that seemed like a bad UX.

To sort this out, it made more sense to just branch early based on whether a hostname had been provided or not. This also has a symmetry with the flags because we can ignore --force entirely after the --hostname block.

williammartin · 2024-01-18T12:16:20Z

pkg/cmd/auth/setupgit/setupgit_test.go

+
+			_, err = cmd.ExecuteC()
+			if tt.wantsErr {
+				require.Error(t, err)


Changed these to use require which I'm quite opinionated about.

williammartin · 2024-01-18T12:16:52Z

pkg/cmd/auth/setupgit/setupgit_test.go

 		cfgStubs           func(*testing.T, config.Config)
 		expectedHostsSetup []string
-		expectedErr        string
+		expectedErr        error


We're testing the return from a function, so I'd rather use the real type rather than the string form of that type like we might test in the stdout.

williammartin

Thanks for your work on this. I reworked a few small things in the last commit and commented why on the PR.

rajhawaldar · 2024-01-18T15:02:17Z

Thanks for your work on this. I reworked a few small things in the last commit and commented why on the PR.

Thanks @williammartin! I learnt few new things from this pull request.
This will definitely help me in future contributions!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.124.0` -> `v4.128.0` | | [cli/cli](https://togithub.com/cli/cli) | minor | `v2.42.1` -> `v2.43.1` | | [junegunn/fzf](https://togithub.com/junegunn/fzf) | patch | `0.46.0` -> `0.46.1` | | [marcosnils/bin](https://togithub.com/marcosnils/bin) | patch | `v0.17.2` -> `v0.17.3` | | [nektos/act](https://togithub.com/nektos/act) | patch | `v0.2.57` -> `v0.2.59` | | [sigstore/cosign](https://togithub.com/sigstore/cosign) | patch | `v2.2.2` -> `v2.2.3` | | [simulot/immich-go](https://togithub.com/simulot/immich-go) | minor | `0.9.12` -> `0.10.0` | | [wagoodman/dive](https://togithub.com/wagoodman/dive) | minor | `v0.11.0` -> `v0.12.0` | | [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor | `v0.169.0` -> `v0.170.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.128.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.128.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.127.1...v4.128.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.128.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.128.0) | aquaproj/aqua-registry@v4.127.1...v4.128.0 #### 🎉 New Packages [#19594](https://togithub.com/aquaproj/aqua-registry/issues/19594) [gitea.com/gitea/tea](https://gitea.com/gitea/tea): Command line tool to interact with Gitea servers [#19593](https://togithub.com/aquaproj/aqua-registry/issues/19593) [gitlab.com/gitlab-org/cli](https://gitlab.com/gitlab-org/cli): A GitLab CLI tool bringing GitLab to your command line > \[!NOTE] > Update aqua-renovate-config to 2.0.0 or newer > To update these packages by Renovate, please update aqua-renovate-config to 2.0.0 or newer > https://github.com/aquaproj/aqua-renovate-config/releases/tag/2.0.0 > \[!WARNING] > These packages have several restriction at the moment. > > - `aqua g` can't get the version, so you need to edit the version manually > - `aqua update` doesn't support these packages ### [`v4.127.1`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.127.1) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.127.0...v4.127.1) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.127.1) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.127.1) | aquaproj/aqua-registry@v4.127.0...v4.127.1 #### Fixes [#19544](https://togithub.com/aquaproj/aqua-registry/issues/19544) eza-community/eza: Support darwin and windows/arm64 using cargo > \[!WARNING] > To support darwin and windows/arm64, aqua >= v2.23.0 is required [#19568](https://togithub.com/aquaproj/aqua-registry/issues/19568) sharkdp/bat: Regenerate config by `cmdx s` [#19591](https://togithub.com/aquaproj/aqua-registry/issues/19591) swaggo/swag: Follow up changes of swag v1.16.3 ### [`v4.127.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.127.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.126.0...v4.127.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.127.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.127.0) | aquaproj/aqua-registry@v4.126.0...v4.127.0 #### 🎉 New Packages [#19518](https://togithub.com/aquaproj/aqua-registry/issues/19518) [crates.io/eza](https://crates.io/crates/eza): A modern replacement for ls [@Omochice](https://togithub.com/Omochice) > \[!NOTE] > We will merge this package with `eza-community/eza`. > Now we can't merge these packages due to the technical issue[https://github.com/aquaproj/aqua/issues/2649](https://togithub.com/aquaproj/aqua/issues/2649)49 #### Fixes [#19530](https://togithub.com/aquaproj/aqua-registry/issues/19530) eza-community/eza: Regenerate config by `cmdx s` [#19533](https://togithub.com/aquaproj/aqua-registry/issues/19533) okta/okta-aws-cli: Follow up changes of okta-aws-cli v2.0.1 #### 🎉 New Contributors Thank you for your contribution! [@Omochice](https://togithub.com/Omochice) [#19518](https://togithub.com/aquaproj/aqua-registry/issues/19518) ### [`v4.126.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.126.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.125.1...v4.126.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.126.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.126.0) | aquaproj/aqua-registry@v4.125.1...v4.126.0 #### 🎉 New Packages [#13513](https://togithub.com/aquaproj/aqua-registry/issues/13513) [#19465](https://togithub.com/aquaproj/aqua-registry/issues/19465) [loft-sh/devpod](https://togithub.com/loft-sh/devpod): Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker [@CrystalMethod](https://togithub.com/CrystalMethod) ### [`v4.125.1`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.125.1) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.125.0...v4.125.1) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.125.1) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.125.1) | aquaproj/aqua-registry@v4.125.0...v4.125.1 #### Fixes [#19450](https://togithub.com/aquaproj/aqua-registry/issues/19450) lxc/incus: Follow up changes of incus v0.5.1 [#19447](https://togithub.com/aquaproj/aqua-registry/issues/19447) kool-dev/kool: Follow up changes of kool 3.0.0 [#19442](https://togithub.com/aquaproj/aqua-registry/issues/19442) mattn/zig-update: Follow up changes of zig-update [#19439](https://togithub.com/aquaproj/aqua-registry/issues/19439) cli/cli: Disable rosetta2 and use files for darwin/arm64 ### [`v4.125.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.125.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.124.0...v4.125.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.125.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.125.0) | aquaproj/aqua-registry@v4.124.0...v4.125.0 #### 🎉 New Packages [#19388](https://togithub.com/aquaproj/aqua-registry/issues/19388) [erebe/wstunnel](https://togithub.com/erebe/wstunnel): Tunnel all your traffic over Websocket or HTTP2 - Bypass firewalls/DPI [@CrystalMethod](https://togithub.com/CrystalMethod) </details> <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.43.1`](https://togithub.com/cli/cli/releases/tag/v2.43.1): GitHub CLI 2.43.1 [Compare Source](https://togithub.com/cli/cli/compare/v2.43.0...v2.43.1) #### What's Changed - Fix label create regression in v2.43.0 by [@williammartin](https://togithub.com/williammartin) in [https://github.com/cli/cli/pull/8653](https://togithub.com/cli/cli/pull/8653) **Full Changelog**: cli/cli@v2.43.0...v2.43.1 ### [`v2.43.0`](https://togithub.com/cli/cli/releases/tag/v2.43.0): GitHub CLI 2.43.0 [Compare Source](https://togithub.com/cli/cli/compare/v2.42.1...v2.43.0) #### Special note With this release, the GitHub CLI team sees [@samcoe](https://togithub.com/samcoe) off to new adventures beyond GitHub! 😿 Sam has been an amazing maintainer and colleague who has helped so many people adopt `gh` while trying to connect with the community regarding its needs. There will forever be a Sam-shaped hole no one can fill but hope he continues to be a part wherever his whirlwind journey takes him! ❤️ #### What's Changed - Remove project JSON formatting objects by [@heaths](https://togithub.com/heaths) in [https://github.com/cli/cli/pull/8541](https://togithub.com/cli/cli/pull/8541) - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8467](https://togithub.com/cli/cli/pull/8467) - build(deps): bump actions/download-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8466](https://togithub.com/cli/cli/pull/8466) - Add option --json for gh variable list by [@w1mvy](https://togithub.com/w1mvy) in [https://github.com/cli/cli/pull/8516](https://togithub.com/cli/cli/pull/8516) - Add `--json` export flag for release list by [@v1v](https://togithub.com/v1v) in [https://github.com/cli/cli/pull/8474](https://togithub.com/cli/cli/pull/8474) - 📝 (search/repos) add usage tips for --archived=false by [@shion1305](https://togithub.com/shion1305) in [https://github.com/cli/cli/pull/8391](https://togithub.com/cli/cli/pull/8391) - fix: Prevent nil dereference in `pr view`. by [@octo](https://togithub.com/octo) in [https://github.com/cli/cli/pull/8566](https://togithub.com/cli/cli/pull/8566) - Fix some typos raised by codespell by [@fpistm](https://togithub.com/fpistm) in [https://github.com/cli/cli/pull/8589](https://togithub.com/cli/cli/pull/8589) - Add force flag to setup-git command by [@rajhawaldar](https://togithub.com/rajhawaldar) in [https://github.com/cli/cli/pull/8552](https://togithub.com/cli/cli/pull/8552) - build(deps): bump actions/cache from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8594](https://togithub.com/cli/cli/pull/8594) - Feature: output URL for newly created repo by [@leevic31](https://togithub.com/leevic31) in [https://github.com/cli/cli/pull/8574](https://togithub.com/cli/cli/pull/8574) - Update Arch repo to \[extra] by [@Xeonacid](https://togithub.com/Xeonacid) in [https://github.com/cli/cli/pull/8607](https://togithub.com/cli/cli/pull/8607) - build(deps): bump microsoft/setup-msbuild from 1.3.1 to 1.3.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/cli/cli/pull/8629](https://togithub.com/cli/cli/pull/8629) - fix(pr create): clarify refspec to push to correct branch in the event of a conflicting tag by [@arunsathiya](https://togithub.com/arunsathiya) in [https://github.com/cli/cli/pull/8618](https://togithub.com/cli/cli/pull/8618) - Send activity signals during non-interactive codespace SSH command by [@dmgardiner25](https://togithub.com/dmgardiner25) in [https://github.com/cli/cli/pull/8639](https://togithub.com/cli/cli/pull/8639) - Upgrade cli/go-gh to v2.5.0 for home-manager fix by [@andyfeller](https://togithub.com/andyfeller) in [https://github.com/cli/cli/pull/8647](https://togithub.com/cli/cli/pull/8647) #### New Contributors - [@w1mvy](https://togithub.com/w1mvy) made their first contribution in [https://github.com/cli/cli/pull/8516](https://togithub.com/cli/cli/pull/8516) - [@v1v](https://togithub.com/v1v) made their first contribution in [https://github.com/cli/cli/pull/8474](https://togithub.com/cli/cli/pull/8474) - [@octo](https://togithub.com/octo) made their first contribution in [https://github.com/cli/cli/pull/8566](https://togithub.com/cli/cli/pull/8566) - [@fpistm](https://togithub.com/fpistm) made their first contribution in [https://github.com/cli/cli/pull/8589](https://togithub.com/cli/cli/pull/8589) - [@leevic31](https://togithub.com/leevic31) made their first contribution in [https://github.com/cli/cli/pull/8574](https://togithub.com/cli/cli/pull/8574) - [@Xeonacid](https://togithub.com/Xeonacid) made their first contribution in [https://github.com/cli/cli/pull/8607](https://togithub.com/cli/cli/pull/8607) **Full Changelog**: cli/cli@v2.42.1...v2.43.0 </details> <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.46.1`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#0461) [Compare Source](https://togithub.com/junegunn/fzf/compare/0.46.0...0.46.1) - Bug fixes and improvements - Fixed Windows binaries - Downgraded Go version to 1.20 to support older versions of Windows - https://tip.golang.org/doc/go1.21#windows - Updated [rivo/uniseg](https://togithub.com/rivo/uniseg) dependency to v0.4.6 </details> <details> <summary>marcosnils/bin (marcosnils/bin)</summary> ### [`v0.17.3`](https://togithub.com/marcosnils/bin/releases/tag/v0.17.3) [Compare Source](https://togithub.com/marcosnils/bin/compare/v0.17.2...v0.17.3) #### Changelog - [`9da887d`](https://togithub.com/marcosnils/bin/commit/9da887d) allow to install and remove binaries in relative paths ([#186](https://togithub.com/marcosnils/bin/issues/186)) </details> <details> <summary>nektos/act (nektos/act)</summary> ### [`v0.2.59`](https://togithub.com/nektos/act/releases/tag/v0.2.59) [Compare Source](https://togithub.com/nektos/act/compare/v0.2.58...v0.2.59) #### Changelog ##### New Features - [`12c0c42`](https://togithub.com/nektos/act/commit/12c0c42) feat: correctly use the xdg library, which has the side effect to fix the config survey ([#2195](https://togithub.com/nektos/act/issues/2195)) ##### Other - [`b7a8145`](https://togithub.com/nektos/act/commit/b7a8145) chore: bump VERSION to 0.2.59 ### [`v0.2.58`](https://togithub.com/nektos/act/releases/tag/v0.2.58) [Compare Source](https://togithub.com/nektos/act/compare/v0.2.57...v0.2.58) #### Changelog ##### New Features - [`f055d4a`](https://togithub.com/nektos/act/commit/f055d4a) feat: support offline mode ([#2128](https://togithub.com/nektos/act/issues/2128)) - [`f7a846d`](https://togithub.com/nektos/act/commit/f7a846d) feat: cli option to enable the new action cache ([#1954](https://togithub.com/nektos/act/issues/1954)) ##### Bug fixes - [`054caec`](https://togithub.com/nektos/act/commit/054caec) fix: use correct path to toolcache ([#1494](https://togithub.com/nektos/act/issues/1494)) - [`5e0d29d`](https://togithub.com/nektos/act/commit/5e0d29d) fix: improve warning about remote not found ([#2169](https://togithub.com/nektos/act/issues/2169)) - [`6dd6725`](https://togithub.com/nektos/act/commit/6dd6725) fix: improve new-action-cache fetch failure error ([#2172](https://togithub.com/nektos/act/issues/2172)) - [`09d4b5d`](https://togithub.com/nektos/act/commit/09d4b5d) fix: subpath actions via new artifact cache ([#2170](https://togithub.com/nektos/act/issues/2170)) - [`a6ec2c1`](https://togithub.com/nektos/act/commit/a6ec2c1) fix: improve action not found error ([#2171](https://togithub.com/nektos/act/issues/2171)) - [`6091094`](https://togithub.com/nektos/act/commit/6091094) fix: write default config in XDG config dir to avoid cluttering the HOME directory by default ([#2140](https://togithub.com/nektos/act/issues/2140)) - [`7f7d84b`](https://togithub.com/nektos/act/commit/7f7d84b) fix: match cache `restore-keys` in creation reverse order ([#2153](https://togithub.com/nektos/act/issues/2153)) ##### Other - [`3ed38d8`](https://togithub.com/nektos/act/commit/3ed38d8) chore: bump VERSION to 0.2.58 - [`0dbf44c`](https://togithub.com/nektos/act/commit/0dbf44c) build(deps): bump github.com/opencontainers/runc from 1.1.7 to 1.1.12 ([#2187](https://togithub.com/nektos/act/issues/2187)) - [`6dcf9bc`](https://togithub.com/nektos/act/commit/6dcf9bc) build(deps): bump github.com/moby/buildkit from 0.11.5 to 0.12.5 ([#2188](https://togithub.com/nektos/act/issues/2188)) - [`df61c7f`](https://togithub.com/nektos/act/commit/df61c7f) build(deps): bump github.com/containerd/containerd from 1.6.19 to 1.6.26 ([#2189](https://togithub.com/nektos/act/issues/2189)) - [`36e0261`](https://togithub.com/nektos/act/commit/36e0261) build(deps): bump github.com/opencontainers/image-spec ([#2167](https://togithub.com/nektos/act/issues/2167)) - [`46dc2ff`](https://togithub.com/nektos/act/commit/46dc2ff) build(deps): bump github.com/moby/buildkit from 0.12.4 to 0.12.5 ([#2186](https://togithub.com/nektos/act/issues/2186)) - [`5a80a04`](https://togithub.com/nektos/act/commit/5a80a04) refactor: filecollector into new package ([#2174](https://togithub.com/nektos/act/issues/2174)) - [`4ca35d2`](https://togithub.com/nektos/act/commit/4ca35d2) build(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 ([#2175](https://togithub.com/nektos/act/issues/2175)) - [`424fd5e`](https://togithub.com/nektos/act/commit/424fd5e) refactor(cmd/root): simplify `parseEnvs` ([#2162](https://togithub.com/nektos/act/issues/2162)) - [`6a8c42a`](https://togithub.com/nektos/act/commit/6a8c42a) Add containerd's normalized architectures to archMapper ([#2168](https://togithub.com/nektos/act/issues/2168)) - [`c215e08`](https://togithub.com/nektos/act/commit/c215e08) build(deps): bump megalinter/megalinter from 7.7.0 to 7.8.0 ([#2164](https://togithub.com/nektos/act/issues/2164)) - [`8072a00`](https://togithub.com/nektos/act/commit/8072a00) WorkflowDispatchConfig supports multiple yaml node kinds ([#2123](https://togithub.com/nektos/act/issues/2123)) - [`15bb54f`](https://togithub.com/nektos/act/commit/15bb54f) build(deps): bump actions/upload-artifact from 3 to 4 ([#2133](https://togithub.com/nektos/act/issues/2133)) - [`cd40f3f`](https://togithub.com/nektos/act/commit/cd40f3f) ci: automatic merge PRs created by a maintainer and approved by 1 other maintainer ([#2156](https://togithub.com/nektos/act/issues/2156)) - [`adbe229`](https://togithub.com/nektos/act/commit/adbe229) Add support for NetBSD ([#2023](https://togithub.com/nektos/act/issues/2023)) - [`96d6cf8`](https://togithub.com/nektos/act/commit/96d6cf8) build(deps): bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 ([#2149](https://togithub.com/nektos/act/issues/2149)) - [`ef5746b`](https://togithub.com/nektos/act/commit/ef5746b) build(deps): bump golang.org/x/term from 0.15.0 to 0.16.0 ([#2148](https://togithub.com/nektos/act/issues/2148)) </details> <details> <summary>sigstore/cosign (sigstore/cosign)</summary> ### [`v2.2.3`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v223) [Compare Source](https://togithub.com/sigstore/cosign/compare/v2.2.2...v2.2.3) #### Bug Fixes - Fix race condition on verification with multiple signatures attached to image ([#3486](https://togithub.com/sigstore/cosign/issues/3486)) - fix(clean): Fix clean cmd for private registries ([#3446](https://togithub.com/sigstore/cosign/issues/3446)) - Fixed BYO PKI verification ([#3427](https://togithub.com/sigstore/cosign/issues/3427)) #### Features - Allow for option in cosign attest and attest-blob to upload attestation as supported in Rekor ([#3466](https://togithub.com/sigstore/cosign/issues/3466)) - Add support for OpenVEX predicate type ([#3405](https://togithub.com/sigstore/cosign/issues/3405)) #### Documentation - Resolves [#3088](https://togithub.com/sigstore/cosign/issues/3088): `version` sub-command expected behaviour documentation and testing ([#3447](https://togithub.com/sigstore/cosign/issues/3447)) - add examples for cosign attach signature cmd ([#3468](https://togithub.com/sigstore/cosign/issues/3468)) #### Misc - Remove CertSubject function ([#3467](https://togithub.com/sigstore/cosign/issues/3467)) - Use local rekor and fulcio instances in e2e tests ([#3478](https://togithub.com/sigstore/cosign/issues/3478)) #### Contributors - aalsabag - Bob Callaway - Carlos Tadeu Panato Junior - Colleen Murphy - Hayden B - Mukuls77 - Omri Bornstein - Puerco - vivek kumar sahu </details> <details> <summary>simulot/immich-go (simulot/immich-go)</summary> ### [`v0.10.0`](https://togithub.com/simulot/immich-go/releases/tag/0.10.0) [Compare Source](https://togithub.com/simulot/immich-go/compare/0.9.12...0.10.0) #### Changelog - [`0d8a166`](https://togithub.com/simulot/immich-go/commit/0d8a166) Merge branch 'main' into [#135](https://togithub.com/simulot/immich-go/issues/135)-feat--use-the-searchAssets-API-to-workaroud-server's-timeout - [`13e6ba4`](https://togithub.com/simulot/immich-go/commit/13e6ba4) Update readme.md ([#137](https://togithub.com/simulot/immich-go/issues/137)) - [`815ef70`](https://togithub.com/simulot/immich-go/commit/815ef70) fix: [#131](https://togithub.com/simulot/immich-go/issues/131) panic syntax error in pattern - [`a51e022`](https://togithub.com/simulot/immich-go/commit/a51e022) fix: [#135](https://togithub.com/simulot/immich-go/issues/135) use the searchAssets API to workaround server's timeout </details> <details> <summary>wagoodman/dive (wagoodman/dive)</summary> ### [`v0.12.0`](https://togithub.com/wagoodman/dive/releases/tag/v0.12.0) [Compare Source](https://togithub.com/wagoodman/dive/compare/v0.11.0...v0.12.0) ### Changelog #### [v0.12.0](https://togithub.com/wagoodman/dive/tree/v0.12.0) (2024-02-02) [Full Changelog](https://togithub.com/wagoodman/dive/compare/v0.11.0...v0.12.0) ##### Added Features - Can we do docker layer wise scan for vulnerability detection \[[Issue #465](https://togithub.com/wagoodman/dive/issues/465)] - How to use Dive in gitlab CI Securely? \[[Issue #493](https://togithub.com/wagoodman/dive/issues/493)] ##### Bug Fixes - Dive always fail when trying to fetch local image \[[Issue #462](https://togithub.com/wagoodman/dive/issues/462)] - Unable to analyze the image using dive (Docker 25+ compatibility) \[[Issue #498](https://togithub.com/wagoodman/dive/issues/498)] \[[PR #500](https://togithub.com/wagoodman/dive/pull/500)] \[[tbroyer](https://togithub.com/tbroyer)] ##### Additional Changes - Bump to more recent go version, remove no longer required overrides \[[PR #461](https://togithub.com/wagoodman/dive/pull/461)] \[[SuperSandro2000](https://togithub.com/SuperSandro2000)] - docs: Adds instructions for snap installation \[[PR #484](https://togithub.com/wagoodman/dive/pull/484)] \[[gruyaume](https://togithub.com/gruyaume)] - DIVE_VERSION does not need to be exported \[[PR #492](https://togithub.com/wagoodman/dive/pull/492)] \[[ReneNyffenegger](https://togithub.com/ReneNyffenegger)] - fix(sec): upgrade golang.org/x/net to 0.17.0 \[[PR #503](https://togithub.com/wagoodman/dive/pull/503)] \[[suguds](https://togithub.com/suguds)] </details> <details> <summary>weaveworks/eksctl (weaveworks/eksctl)</summary> ### [`v0.170.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.170.0): eksctl 0.170.0 (permalink) [Compare Source](https://togithub.com/weaveworks/eksctl/compare/0.169.0-rc.0...0.170.0-rc.0) ### Release v0.170.0 #### 🚀 Features - Add support for Access Entry type ([#7522](https://togithub.com/weaveworks/eksctl/issues/7522)) #### 🎯 Improvements - Skip draining managed nodegroups when deleting cluster ([#7515](https://togithub.com/weaveworks/eksctl/issues/7515)) - Expand Karpenter settings.aws block to settings for v0.33.0 and greater ([#7503](https://togithub.com/weaveworks/eksctl/issues/7503)) #### 📝 Documentation - docs(fargate): eksctl update command is deprecated, use upgrade instead ([#7517](https://togithub.com/weaveworks/eksctl/issues/7517)) #### Acknowledgments The eksctl maintainers would like to sincerely thank: [@skl](https://togithub.com/skl) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add force flag to setup-git command

d357568

rajhawaldar requested a review from a team as a code owner January 10, 2024 02:31

rajhawaldar requested review from williammartin and removed request for a team January 10, 2024 02:31

cliAutomation added the external pull request originating outside of the CLI core team label Jan 10, 2024

rajhawaldar mentioned this pull request Jan 10, 2024

with no logged in hosts setup-git should default to github.com #8525

Closed

Merge branch 'trunk' into add-force-to-setup-git

2ae4547

williammartin requested changes Jan 10, 2024

View reviewed changes

rajhawaldar added 2 commits January 11, 2024 09:15

test cases improvement

f7835a8

Merge branch 'trunk' into add-force-to-setup-git

a4ded25

rajhawaldar requested a review from williammartin January 11, 2024 16:10

rajhawaldar added 2 commits January 13, 2024 08:09

Merge branch 'trunk' into add-force-to-setup-git

2c9340a

use ghe.io instead of foo

0d1697e

williammartin requested changes Jan 15, 2024

View reviewed changes

improvement as per review comments

76a008a

rajhawaldar commented Jan 16, 2024

View reviewed changes

pkg/cmd/auth/setupgit/setupgit_test.go Show resolved Hide resolved

Merge branch 'trunk' into add-force-to-setup-git

ae1190d

rajhawaldar requested a review from williammartin January 16, 2024 16:17

Rework setupgit into separate branches

ff81dc4

williammartin reviewed Jan 18, 2024

View reviewed changes

williammartin approved these changes Jan 18, 2024

View reviewed changes

williammartin merged commit 76ec5d5 into cli:trunk Jan 18, 2024

arunsathiya mentioned this pull request Jan 24, 2024

fix(pr create): clarify refspec to push to correct branch in the event of a conflicting tag #8618

Merged

BrewTestBot mentioned this pull request Jan 31, 2024

gh 2.43.0 Homebrew/homebrew-core#161419

Closed

	cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Add credential helper for unknown host")
	cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Force setup even if the host is not known. Must be used in conjunction with `--hostname`")

Add force flag to setup-git command #8552

Add force flag to setup-git command #8552

Uh oh!

Conversation

rajhawaldar commented Jan 10, 2024

Uh oh!

williammartin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

williammartin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williammartin left a comment

Choose a reason for hiding this comment

Uh oh!

rajhawaldar commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants