Skip to content

Improve logging around upload errors#894

Merged
ghengeveld merged 5 commits intomainfrom
improve-upload-logging
Jan 25, 2024
Merged

Improve logging around upload errors#894
ghengeveld merged 5 commits intomainfrom
improve-upload-logging

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jan 18, 2024

Logging file upload errors was basically broken because it didn't properly report back the file name. That's fixed now and I also added this extra info message that attempts to diagnose the problem based on a simple heuristic (does url encoding change the file path at all):

✖ Failed to upload path/to/whoop$.jpg to whoop$.jpg
It seems the file path may contain illegal characters.
Enable the debug option to get more information.
📦 Published PR as canary version: 10.5.2--canary.894.7656791058.0

✨ Test out this PR locally via:

npm install chromatic@10.5.2--canary.894.7656791058.0
# or 
yarn add chromatic@10.5.2--canary.894.7656791058.0

@ghengeveld ghengeveld added the patch Auto: Increment the patch version when merged label Jan 25, 2024
Copy link
Copy Markdown
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵👍🏻

@ghengeveld ghengeveld added the skip-release Auto: Preserve the current version when merged label Jan 25, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 2aeadd2 Jan 25, 2024
@ghengeveld ghengeveld deleted the improve-upload-logging branch January 25, 2024 15:24
@ghengeveld
Copy link
Copy Markdown
Member Author

🚀 PR was released in v10.5.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants