Skip to content

Do not autofix PT004 and PT005#1763

Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom
harupy:do-not-autofix-PT004-and-PT005
Jan 10, 2023
Merged

Do not autofix PT004 and PT005#1763
charliermarsh merged 1 commit intoastral-sh:mainfrom
harupy:do-not-autofix-PT004-and-PT005

Conversation

@harupy
Copy link
Copy Markdown
Contributor

@harupy harupy commented Jan 10, 2023

As @edgarrmondragon commented in #1740 (comment), just renaming fixture doesn't work.

@charliermarsh charliermarsh merged commit b732135 into astral-sh:main Jan 10, 2023
@harupy harupy deleted the do-not-autofix-PT004-and-PT005 branch January 10, 2023 12:30
renovate bot referenced this pull request in ixm-one/pytest-cmake-presets Jan 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.217` ->
`^0.0.218` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.218/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.218/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.218/compatibility-slim/0.0.217)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.218/confidence-slim/0.0.217)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.218`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.218)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.217...v0.0.218)

#### What's Changed

- Implement flake8-simplify SIM112 by
[@&#8203;messense](https://togithub.com/messense) in
[https://github.com/charliermarsh/ruff/pull/1764](https://togithub.com/charliermarsh/ruff/pull/1764)
- Do not autofix PT004 and PT005 by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1763](https://togithub.com/charliermarsh/ruff/pull/1763)
- Disable release builds on CI by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1761](https://togithub.com/charliermarsh/ruff/pull/1761)
- Move CONTRIBUTING.md to top-level by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1768](https://togithub.com/charliermarsh/ruff/pull/1768)
- \[`flake8-bandit`] Add Rule for `S508` (snmp insecure version) &
`S509` (snmp weak cryptography) by
[@&#8203;saadmk11](https://togithub.com/saadmk11) in
[https://github.com/charliermarsh/ruff/pull/1771](https://togithub.com/charliermarsh/ruff/pull/1771)
- Generate RuleCode::origin() via macro by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[https://github.com/charliermarsh/ruff/pull/1770](https://togithub.com/charliermarsh/ruff/pull/1770)
- Disable doctests by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1772](https://togithub.com/charliermarsh/ruff/pull/1772)
- Enable isort-style `required-imports` enforcement by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1762](https://togithub.com/charliermarsh/ruff/pull/1762)
- Pyupgrade: Format specifiers by
[@&#8203;colin99d](https://togithub.com/colin99d) in
[https://github.com/charliermarsh/ruff/pull/1594](https://togithub.com/charliermarsh/ruff/pull/1594)
- Avoid B023 false-positives for some common builtins by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1776](https://togithub.com/charliermarsh/ruff/pull/1776)

**Full Changelog**:
astral-sh/ruff@v0.0.217...v0.0.218

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzQuOTcuMSJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Czaki added a commit to Czaki/ruff that referenced this pull request Jan 11, 2023
charliermarsh added a commit that referenced this pull request Jan 11, 2023
When checking changes in the 0.0.218 release I noticed that auto fixing
PT004 and PT005 was disabled but this change was not reflected in
README. So I create this small PR to do this.

Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants