Actually, we only have one attribute that accepts a string literal, and if we're accepting multiple arguments, we would want to accept commas between them, so we can make arguments be an Option.

Comma-separated arguments are now accepted, do should comma+space also be accepted?

Ah, no sorry, what I was getting at is that we don't have any multi-argument attributes, so we shouldn't bother either with parsing multiple arguments, with or without commas. We can just parse ( STRING ).

Alright, but now it is implemented, do you want it removed? It's like 2 lines and all the scaffolding is there now if there's a need/want for features that take advantage of recipe attributes with arguments. Off the top of my head it could be stuff like [linux("arm64", "amd64")] that enables recipes based on OS + Architecture, or adding kernel version for requirements etc.

But I respect if you invoke YAGNI, then I'll revert it.

I agree we'll probably add it later, but that could be a while, so I'd assume just remove it. It also makes Attribute::with_arguments simpler, since it can take an Option instead of a Vec.