fix(OverflowMenu): add stopPropagation call to handleClick method (#9816)

rzhekova · web-flow · commit c53e70818d9d · 2021-10-07T15:44:25.000Z
diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu-test.js b/packages/react/src/components/OverflowMenu/OverflowMenu-test.js
@@ -160,6 +160,15 @@ describe('OverflowMenu', () => {
       );
     });
 
+    it('fires onClick only once per button click', () => {
+      const mockOnClick = jest.fn();
+      const rootWrapper = mount(<OverflowMenu onClick={mockOnClick} />);
+
+      rootWrapper.find('button').simulate('click');
+
+      expect(mockOnClick).toHaveBeenCalledTimes(1);
+    });
+
     it('should NOT toggle state in response to Enter or Space when the menu is open', () => {
       const enterKey = 13;
       const spaceKey = 32;
diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu.js b/packages/react/src/components/OverflowMenu/OverflowMenu.js
@@ -278,6 +278,7 @@ class OverflowMenu extends Component {
   }
 
   handleClick = (evt) => {
+    evt.stopPropagation();
     if (!this._menuBody || !this._menuBody.contains(evt.target)) {
       this.setState({ open: !this.state.open });
       this.props.onClick(evt);

Original file line number	Diff line number	Diff line change
`@@ -278,6 +278,7 @@ class OverflowMenu extends Component {`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`handleClick = (evt) => {`
	`281`	`+ evt.stopPropagation();`
`281`	`282`	`if (!this._menuBody \|\| !this._menuBody.contains(evt.target)) {`
`282`	`283`	`this.setState({ open: !this.state.open });`
`283`	`284`	`this.props.onClick(evt);`