fix: make ActionableNotification subtitle proptypes node to allow objects (#13821)

crhuff-ibm · tay1orjones · kodiakhq[bot] · web-flow · commit c3ea7c86a458 · 2023-06-23T18:21:08.000Z
* fix: make notification subtitle proptypes node to allow objects

* fix: publicAPI snap

* feat(notification): only render action button when label is provided

* chore: update snapshot

* fix(notification): make actionButtonLabel optional

---------

Co-authored-by: Taylor Jones &lt;taylor.jones826@gmail.com&gt;
Co-authored-by: kodiakhq[bot] &lt;49736102+kodiakhq[bot]@users.noreply.github.com&gt;
diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -108,7 +108,6 @@ Map {
     },
     "propTypes": Object {
       "actionButtonLabel": Object {
-        "isRequired": true,
         "type": "string",
       },
       "aria-label": Object {
@@ -166,7 +165,7 @@ Map {
         "type": "string",
       },
       "subtitle": Object {
-        "type": "string",
+        "type": "node",
       },
       "title": Object {
         "type": "string",
diff --git a/packages/react/src/components/Notification/Notification.tsx b/packages/react/src/components/Notification/Notification.tsx
@@ -822,7 +822,7 @@ export interface ActionableNotificationProps
   /**
    * Pass in the action button label that will be rendered within the ActionableNotification.
    */
-  actionButtonLabel: string;
+  actionButtonLabel?: string;
 
   /**
    * Provide a description for "close" icon button that can be read by screen readers
@@ -905,7 +905,7 @@ export interface ActionableNotificationProps
   /**
    * Specify the subtitle
    */
-  subtitle?: string;
+  subtitle?: ReactNode;
 
   /**
    * Specify the title
@@ -1001,9 +1001,11 @@ export function ActionableNotification({
         </div>
       </div>
 
-      <NotificationActionButton onClick={onActionButtonClick} inline={inline}>
-        {actionButtonLabel}
-      </NotificationActionButton>
+      {actionButtonLabel && (
+        <NotificationActionButton onClick={onActionButtonClick} inline={inline}>
+          {actionButtonLabel}
+        </NotificationActionButton>
+      )}
 
       {!hideCloseButton && (
         <NotificationButton
@@ -1020,7 +1022,7 @@ ActionableNotification.propTypes = {
   /**
    * Pass in the action button label that will be rendered within the ActionableNotification.
    */
-  actionButtonLabel: PropTypes.string.isRequired,
+  actionButtonLabel: PropTypes.string,
 
   /**
    * Provide a description for "close" icon button that can be read by screen readers
@@ -1112,7 +1114,7 @@ ActionableNotification.propTypes = {
   /**
    * Specify the subtitle
    */
-  subtitle: PropTypes.string,
+  subtitle: PropTypes.node,
 
   /**
    * Specify the title
