fix(MultiSelect): remove aria hidden on ListBoxSelection button (#9924)

dakahn · tay1orjones · kodiakhq[bot] · web-flow · commit 5757544eeb50 · 2021-10-30T02:36:06.000Z
* fix(MultiSelect): remove aria hidden on ListBoxSelection

* chore: update snaps

Co-authored-by: Taylor Jones &lt;tay1orjones@users.noreply.github.com&gt;
Co-authored-by: Taylor Jones &lt;taylor.jones826@gmail.com&gt;
Co-authored-by: kodiakhq[bot] &lt;49736102+kodiakhq[bot]@users.noreply.github.com&gt;
diff --git a/packages/react/src/components/ListBox/ListBoxSelection.js b/packages/react/src/components/ListBox/ListBoxSelection.js
@@ -76,7 +76,6 @@ const ListBoxSelection = ({
         onKeyDown={handleOnKeyDown}
         disabled={disabled}
         aria-label={t('clear.all')}
-        aria-hidden={true}
         title={description}>
         <Close16 />
       </div>
@@ -89,7 +88,6 @@ const ListBoxSelection = ({
       onClick={handleOnClick}
       onKeyDown={handleOnKeyDown}
       aria-label={description}
-      aria-hidden={true}
       title={description}>
       {selectionCount}
       <Close16 />
diff --git a/packages/react/src/components/ListBox/__tests__/__snapshots__/ListBoxField-test.js.snap b/packages/react/src/components/ListBox/__tests__/__snapshots__/ListBoxField-test.js.snap
@@ -14,7 +14,6 @@ exports[`ListBoxField should render 1`] = `
       translateWithId={[Function]}
     >
       <div
-        aria-hidden={true}
         aria-label="Clear selected item"
         className="bx--list-box__selection"
         onClick={[Function]}
diff --git a/packages/react/src/components/ListBox/__tests__/__snapshots__/ListBoxSelection-test.js.snap b/packages/react/src/components/ListBox/__tests__/__snapshots__/ListBoxSelection-test.js.snap
@@ -34,7 +34,6 @@ exports[`ListBoxSelection should render 1`] = `
   }
 >
   <div
-    aria-hidden={true}
     aria-label="translation"
     className="bx--list-box__selection"
     onClick={[Function]}
@@ -116,7 +115,6 @@ exports[`ListBoxSelection should render 2`] = `
       3
     </span>
     <div
-      aria-hidden={true}
       aria-label="translation"
       className="bx--tag__close-icon"
       onClick={[Function]}

Original file line number	Diff line number	Diff line change
@@ -14,7 +14,6 @@ exports[`ListBoxField should render 1`] = `
`14`	`14`	`translateWithId={[Function]}`
`15`	`15`	`>`
`16`	`16`	`<div`
`17`		`- aria-hidden={true}`
`18`	`17`	`aria-label="Clear selected item"`
`19`	`18`	`className="bx--list-box__selection"`
`20`	`19`	`onClick={[Function]}`
Original file line number	Diff line number	Diff line change
@@ -34,7 +34,6 @@ exports[`ListBoxSelection should render 1`] = `
`34`	`34`	`}`
`35`	`35`	`>`
`36`	`36`	`<div`
`37`		`- aria-hidden={true}`
`38`	`37`	`aria-label="translation"`
`39`	`38`	`className="bx--list-box__selection"`
`40`	`39`	`onClick={[Function]}`
@@ -116,7 +115,6 @@ exports[`ListBoxSelection should render 2`] = `
`116`	`115`	`3`
`117`	`116`	`</span>`
`118`	`117`	`<div`
`119`		`- aria-hidden={true}`
`120`	`118`	`aria-label="translation"`
`121`	`119`	`className="bx--tag__close-icon"`
`122`	`120`	`onClick={[Function]}`