feat: try to infer sub-package tag#161
Merged
caarlos0 merged 1 commit intocaarlos0:mainfrom Jul 10, 2024
Merged
Conversation
This adds support for inferring a sub-package version by trying to
predict the sub-package tag using the current directory and Git root
path.
For example, running `svu` in a Go mono-repository with multiple
packages won't return the correct tag since it won't be able to parse
the latest tag `ansi/v0.1.2`.
This PR initializes the `--prefix` and `--pattern` when the current
directory doesn't match the Git root making `svu` work without the need
to specify `svu --prefix="ansi/v" --pattern="ansi/*" ...`.
P.S. maybe there's a cleaner way of doing so 🤔
Previously I had this little shell func
```sh
function get-next-version() {
root=$(git rev-parse --show-toplevel)
if [ "$PWD" != "$root" ]; then
local prefix=$(echo -n "$PWD" | sed "s|$root/||g")
svu --prefix="$prefix/v" --pattern="$prefix/*" "$@"
else
svu "$@"
fi
}
```
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
This was referenced Aug 8, 2024
Closed
Owner
|
reverted this for now |
aymanbagabas
added a commit
to aymanbagabas/dotfiles
that referenced
this pull request
Sep 10, 2024
aymanbagabas
added a commit
to aymanbagabas/dotfiles
that referenced
this pull request
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for inferring a sub-package version by trying to predict the sub-package tag using the current directory and Git root path.
For example, running
svuin a Go mono-repository with multiple packages won't return the correct tag since it won't be able to parse the latest tagansi/v0.1.2.This PR initializes the
--prefixand--patternwhen the current directory doesn't match the Git root makingsvuwork without the need to specifysvu --prefix="ansi/v" --pattern="ansi/*" ....P.S. maybe there's a cleaner way of doing so 🤔
Previously I had this little shell func