Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/stardoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.5.3
Choose a base ref
...
head repository: bazelbuild/stardoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.5.4
Choose a head ref
  • 10 commits
  • 30 files changed
  • 7 contributors

Commits on Nov 2, 2022

  1. Expose stardoc() output files as runfiles (#139)

    * Expose stardoc() output files as runfiles
    
    There's currently a nuisance with the `stardoc()` rule that presents
    itself in `rules_python`:
    
        $ git clone https://github.com/bazelbuild/rules_python.git
        $ cd rules_python
        $ git checkout d314e96aaab18f60df50400d61214f7c1d71b8e6
        $ bazel run //docs:update
        cp: cannot stat 'bazel-bin/docs/packaging.md_': No such file or directory
        cp: cannot stat 'bazel-bin/docs/pip.md_': No such file or directory
        cp: cannot stat 'bazel-bin/docs/pip_repository.md_': No such file or directory
        cp: cannot stat 'bazel-bin/docs/python.md_': No such file or directory
    
    A sample of the targets involved look like so:
    
        $ bazel cquery --output=build //docs:update + //docs:packaging-docs
        INFO: Invocation ID: 5fd7a652-0b0d-4827-98f5-c345b38b2178
        INFO: Analyzed 2 targets (0 packages loaded, 0 targets configured).
        INFO: Found 2 targets...
        # /home/jenkins/repos/rules_python/docs/BUILD:153:10
        sh_binary(
          name = "update",
          target_compatible_with = [],
          data = ["//docs:packaging-docs", "//docs:pip-docs", "//docs:pip-repository", "//docs:core-docs"],
          srcs = ["//docs:update.sh"],
        )
        # Rule update instantiated at (most recent call last):
        #   /home/jenkins/repos/rules_python/docs/BUILD:153:10 in <toplevel>
    
        # /home/jenkins/repos/rules_python/docs/BUILD:121:8
        stardoc(
          name = "packaging-docs",
          target_compatible_with = [],
          input = "//python:packaging.bzl",
          deps = ["//docs:packaging_bzl"],
          out = "//docs:packaging.md_",
        )
        # Rule packaging-docs instantiated at (most recent call last):
        #   /home/jenkins/repos/rules_python/docs/BUILD:121:8 in <toplevel>
        # Rule stardoc defined at (most recent call last):
        #   /bazel-cache/phil/bazel/_bazel_phil/adc54b5b09500e464f8a73095f3bd8e3/external/io_bazel_stardoc/stardoc/stardoc.bzl:110:15 in <toplevel>
    
    The `update` target could instead reference the `*.md_` files directly
    instead of referencing the `stardoc()` targets. But it's not obvious
    that this is the desired work flow. It feels like users should be able
    to depend on the `stardoc()` target instead of its predeclared output.
    
    This patch fixes this by adding the predeclared outputs to the
    target's runfiles. That lets the `rules_python` doc update target work
    again.
    
        $ bazel run //docs:update
        'bazel-bin/docs/packaging.md_' -> 'docs/packaging.md'
        'bazel-bin/docs/pip.md_' -> 'docs/pip.md'
        'bazel-bin/docs/pip_repository.md_' -> 'docs/pip_repository.md'
        'bazel-bin/docs/python.md_' -> 'docs/python.md'
    philsc authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    97c0751 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Update rules_pkg to 0.8 (#140)

    Resolves config_setting visibility failures from bazelbuild/bazel#12933:
    
    ```
    ERROR: /var/lib/buildkite-agent/builds/bk-docker-zr2k/bazel-downstream-projects/stardoc/distro/BUILD:33:8: in pkg_tar_impl rule //distro:distro_bins: target '@rules_pkg//pkg/private:private_stamp_detect' is not visible from target '//distro:distro_bins'. Check the visibility declaration of the former target if you think the dependency is legitimate
    ```
    
    See https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1320#018435e1-7429-4329-808a-731599f24623.
    gregestren authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6f274e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    7c5e4fc View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Configuration menu
    Copy the full SHA
    7531bbc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Add license rules (#150)

    Needed for bureaucratic compliance reasons.
    tetromino authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2ce2df8 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Configuration menu
    Copy the full SHA
    aed91e2 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Add support for Bzlmod (#141)

    Input .bzl files are turned into runfiles of a custom Stardoc binary, which allows reusing the Java runfiles library to load the files while taking repository mappings into account.
    fmeum authored May 5, 2023
    Configuration menu
    Copy the full SHA
    ffcb4fb View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    5ecf8df View commit details
    Browse the repository at this point in the history
  2. Test Bzlmod support in CI (#152)

    Required updating the pinned Bazel commit and importing a patch to rules_jvm_external from the Bazel source tree.
    
    Fixes #110
    fmeum authored May 16, 2023
    Configuration menu
    Copy the full SHA
    9c834ae View commit details
    Browse the repository at this point in the history
  3. Add MODULE.bazel and //stardoc/private to distro tarball (#154)

    Needed for a bzlmod-compatible release
    tetromino authored May 16, 2023
    Configuration menu
    Copy the full SHA
    8cd9ecf View commit details
    Browse the repository at this point in the history
Loading