-
Notifications
You must be signed in to change notification settings - Fork 50
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: bazelbuild/stardoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.5.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: bazelbuild/stardoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.5.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 30 files changed
- 7 contributors
Commits on Nov 2, 2022
-
Expose stardoc() output files as runfiles (#139)
* Expose stardoc() output files as runfiles There's currently a nuisance with the `stardoc()` rule that presents itself in `rules_python`: $ git clone https://github.com/bazelbuild/rules_python.git $ cd rules_python $ git checkout d314e96aaab18f60df50400d61214f7c1d71b8e6 $ bazel run //docs:update cp: cannot stat 'bazel-bin/docs/packaging.md_': No such file or directory cp: cannot stat 'bazel-bin/docs/pip.md_': No such file or directory cp: cannot stat 'bazel-bin/docs/pip_repository.md_': No such file or directory cp: cannot stat 'bazel-bin/docs/python.md_': No such file or directory A sample of the targets involved look like so: $ bazel cquery --output=build //docs:update + //docs:packaging-docs INFO: Invocation ID: 5fd7a652-0b0d-4827-98f5-c345b38b2178 INFO: Analyzed 2 targets (0 packages loaded, 0 targets configured). INFO: Found 2 targets... # /home/jenkins/repos/rules_python/docs/BUILD:153:10 sh_binary( name = "update", target_compatible_with = [], data = ["//docs:packaging-docs", "//docs:pip-docs", "//docs:pip-repository", "//docs:core-docs"], srcs = ["//docs:update.sh"], ) # Rule update instantiated at (most recent call last): # /home/jenkins/repos/rules_python/docs/BUILD:153:10 in <toplevel> # /home/jenkins/repos/rules_python/docs/BUILD:121:8 stardoc( name = "packaging-docs", target_compatible_with = [], input = "//python:packaging.bzl", deps = ["//docs:packaging_bzl"], out = "//docs:packaging.md_", ) # Rule packaging-docs instantiated at (most recent call last): # /home/jenkins/repos/rules_python/docs/BUILD:121:8 in <toplevel> # Rule stardoc defined at (most recent call last): # /bazel-cache/phil/bazel/_bazel_phil/adc54b5b09500e464f8a73095f3bd8e3/external/io_bazel_stardoc/stardoc/stardoc.bzl:110:15 in <toplevel> The `update` target could instead reference the `*.md_` files directly instead of referencing the `stardoc()` targets. But it's not obvious that this is the desired work flow. It feels like users should be able to depend on the `stardoc()` target instead of its predeclared output. This patch fixes this by adding the predeclared outputs to the target's runfiles. That lets the `rules_python` doc update target work again. $ bazel run //docs:update 'bazel-bin/docs/packaging.md_' -> 'docs/packaging.md' 'bazel-bin/docs/pip.md_' -> 'docs/pip.md' 'bazel-bin/docs/pip_repository.md_' -> 'docs/pip_repository.md' 'bazel-bin/docs/python.md_' -> 'docs/python.md'Configuration menu - View commit details
-
Copy full SHA for 97c0751 - Browse repository at this point
Copy the full SHA 97c0751View commit details
Commits on Nov 4, 2022
-
Update rules_pkg to 0.8 (#140)
Resolves config_setting visibility failures from bazelbuild/bazel#12933: ``` ERROR: /var/lib/buildkite-agent/builds/bk-docker-zr2k/bazel-downstream-projects/stardoc/distro/BUILD:33:8: in pkg_tar_impl rule //distro:distro_bins: target '@rules_pkg//pkg/private:private_stamp_detect' is not visible from target '//distro:distro_bins'. Check the visibility declaration of the former target if you think the dependency is legitimate ``` See https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1320#018435e1-7429-4329-808a-731599f24623.
Configuration menu - View commit details
-
Copy full SHA for 6f274e9 - Browse repository at this point
Copy the full SHA 6f274e9View commit details
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c5e4fc - Browse repository at this point
Copy the full SHA 7c5e4fcView commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7531bbc - Browse repository at this point
Copy the full SHA 7531bbcView commit details
Commits on Mar 14, 2023
-
Needed for bureaucratic compliance reasons.
Configuration menu - View commit details
-
Copy full SHA for 2ce2df8 - Browse repository at this point
Copy the full SHA 2ce2df8View commit details
Commits on Apr 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aed91e2 - Browse repository at this point
Copy the full SHA aed91e2View commit details
Commits on May 5, 2023
-
Input .bzl files are turned into runfiles of a custom Stardoc binary, which allows reusing the Java runfiles library to load the files while taking repository mappings into account.
Configuration menu - View commit details
-
Copy full SHA for ffcb4fb - Browse repository at this point
Copy the full SHA ffcb4fbView commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ecf8df - Browse repository at this point
Copy the full SHA 5ecf8dfView commit details -
Test Bzlmod support in CI (#152)
Required updating the pinned Bazel commit and importing a patch to rules_jvm_external from the Bazel source tree. Fixes #110
Configuration menu - View commit details
-
Copy full SHA for 9c834ae - Browse repository at this point
Copy the full SHA 9c834aeView commit details -
Add MODULE.bazel and //stardoc/private to distro tarball (#154)
Needed for a bzlmod-compatible release
Configuration menu - View commit details
-
Copy full SHA for 8cd9ecf - Browse repository at this point
Copy the full SHA 8cd9ecfView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.5.3...0.5.4