fix(builtin): pass kwargs from node_repositories helper (#3287)

alexeagle · web-flow · commit b446fa1fb7b6 · 2022-01-26T06:01:46.000-08:00
We were missing test coverage for attributes like node_version being passed to the new toolchain registration
diff --git a/e2e/nodejs_host/BUILD.bazel b/e2e/nodejs_host/BUILD.bazel
@@ -14,6 +14,7 @@ nodejs_test(
         "@nodejs_host//:npm_bin",
         "@nodejs_host//:npm_files",
         "@nodejs_host//:npx_bin",
+        "@npm//:node_modules",
         "@yarn",
         "@yarn//:yarn_bin",
         "@yarn//:yarn_files",
diff --git a/e2e/nodejs_host/WORKSPACE b/e2e/nodejs_host/WORKSPACE
@@ -12,7 +12,11 @@ load("@build_bazel_rules_nodejs//:repositories.bzl", "build_bazel_rules_nodejs_d
 
 build_bazel_rules_nodejs_dependencies()
 
-load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
+load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
+
+node_repositories(
+    node_version = "12.12.0",
+)
 
 yarn_install(
     name = "npm",
diff --git a/e2e/nodejs_host/package.json b/e2e/nodejs_host/package.json
@@ -1,6 +1,7 @@
 {
   "dependencies": {},
   "scripts": {
+    "postinstall": "node -e \"require('assert').equal(process.version, 'v12.12.0')\"",
     "test": "bazel test ..."
   }
 }
diff --git a/internal/node/node_repositories.bzl b/internal/node/node_repositories.bzl
@@ -47,4 +47,4 @@ def node_repositories(**kwargs):
     )
 
     # Install new toolchain under "nodejs" repository name prefix
-    nodejs_register_toolchains(name = "nodejs")
+    nodejs_register_toolchains(name = "nodejs", **kwargs)

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"dependencies": {},`
`3`	`3`	`"scripts": {`
	`4`	`+ "postinstall": "node -e \"require('assert').equal(process.version, 'v12.12.0')\"",`
`4`	`5`	`"test": "bazel test ..."`
`5`	`6`	`}`
`6`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,4 +47,4 @@ def node_repositories(**kwargs):`
`47`	`47`	`)`
`48`	`48`
`49`	`49`	`# Install new toolchain under "nodejs" repository name prefix`
`50`		`- nodejs_register_toolchains(name = "nodejs")`
	`50`	`+ nodejs_register_toolchains(name = "nodejs", **kwargs)`