Add feature to check for ObjcProvider linker info availability#20
Merged
meteorcloudy merged 1 commit intobazel-contrib:mainfrom Aug 21, 2023
Conversation
2b089ee to
f4ab6a2
Compare
Collaborator
|
For future reference, can you put a link to the relevant Bazel change in the PR description or code comment? |
Some rulesets inspect linking information from `ObjcProvider` and fallback to `CcInfo` only if a rule doesn’t propagate an `ObjcProvider`. After `7.0.0-pre.20230724.1` (bazelbuild/bazel@426f225) a `ObjcProvider` will exist, but it won’t have any linking information set. Signed-off-by: Brentley Jones <github@brentleyjones.com>
f4ab6a2 to
078b76e
Compare
Collaborator
Author
|
Added to both. |
meteorcloudy
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rulesets inspect linking information from
ObjcProviderand fallback toCcInfoonly if a rule doesn’t propagate anObjcProvider. After7.0.0-pre.20230724.1(bazelbuild/bazel@426f225) aObjcProviderwill exist, but it won’t have any linking information set.