Skip to content

[traverse] Allow skipping nodes inserted with .replaceWith()#9777

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:issue-4098
Oct 17, 2019
Merged

[traverse] Allow skipping nodes inserted with .replaceWith()#9777
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:issue-4098

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 27, 2019

Q                       A
Fixed Issues? Fixes #4098
Patch: Bug Fix? Yes
Major: Breaking Change? Maybe? I don't think so, but it changes an observable behavior.
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse labels Mar 27, 2019
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Mar 27, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10630/

@nicolo-ribaudo nicolo-ribaudo changed the title [traverse] .skip and .requeue: the last called method wins [traverse] Allow skipping nodes inserted with .replaceWith() Oct 17, 2019
@buildsize
Copy link
Copy Markdown

buildsize bot commented Oct 17, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.73 MB 2.73 MB 27 bytes (0%)
babel-preset-env.min.js 1.65 MB 1.65 MB 25 bytes (0%)
babel.js 2.92 MB 2.92 MB 27 bytes (0%)
babel.min.js 1.61 MB 1.61 MB 25 bytes (0%)
test262.tap 4.84 MB [deleted]

@nicolo-ribaudo nicolo-ribaudo merged commit 43b623c into babel:master Oct 17, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the issue-4098 branch October 17, 2019 22:16
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danez danez danez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling path.skip() on a path that has been replaced with a replaceWith() (or other replace methods) does not skip the traversal. (T7117)

3 participants

@nicolo-ribaudo @babel-bot @danez