Make dir for babel --out-file#8622
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Oct 29, 2019
Merged
Conversation
xtuc
approved these changes
Sep 10, 2018
yarn.lock
Outdated
| "@babel/cli@7.0.0-rc.2": | ||
| version "7.0.0-rc.2" | ||
| resolved "https://registry.yarnpkg.com/@babel/cli/-/cli-7.0.0-rc.2.tgz#0c64762f27ccd3fa255111570b6c404f81181c85" | ||
| "@babel/cli@^7.0.0": |
Member
There was a problem hiding this comment.
I'm not sure why Babel changed here? make-dir doesn't depends on Babel. Maybe we forgot to update the lock file after our own Babel bump.
Currently there's unexpected regression after upgrade from babel 6. On creating file with any depth like dist/index.js the error about not existing directory is thrown. In this diff I modified babel-cli to create deep directory for out-file command. I also replaced `mkdirp` with more supported `make-dir` package which also have official promise support.
93e8bea to
4ab776a
Compare
nicolo-ribaudo
approved these changes
Oct 17, 2019
JLHwung
approved these changes
Oct 18, 2019
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
After it is merged we may also replace output-file-sync by make-dir + fs.writeFileSync.
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's unexpected regression after upgrade from babel 6.
On creating file with any depth like dist/index.js the error about
not existing directory is thrown.
In this diff I modified babel-cli to create deep directory for out-file
command.
I also replaced
mkdirpwith more supportedmake-dirpackage whichalso have official promise support.