Avoid checking Scope.globals multiple times#16619
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Jul 9, 2024
Merged
Conversation
Scope.globals multiple times.Scope.globals multiple times
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57280 |
JLHwung
reviewed
Jul 8, 2024
| } else if (typeof opts === "boolean") { | ||
| noGlobals = opts; | ||
| } | ||
| if (this.parentHasBinding(name, opts)) return true; |
Contributor
There was a problem hiding this comment.
Do we have other parentHasBinding usage? If not maybe we can deprecate and remove this method in Babel 8, as it is trivial to implement.
Member
Author
There was a problem hiding this comment.
It has only this one use.
JLHwung
approved these changes
Jul 8, 2024
nicolo-ribaudo
approved these changes
Jul 8, 2024
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I would not label this as "performance", since the performance different is insignificant
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Previously
hasBindingwas called on each parent scope, which resulted in multiple checks ofScope.globalsandScope.contextVariables.This improvement is small, and I didn't notice a noticeable improvement in
real-case-preset-env-typescript.